Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert OpenGL compatibility version #25

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

p-yukusai
Copy link
Member

We have decided to give up on support for OpenGL 3.1 and opt to keep using OpenGL 3.3, these are the reasons why:

  1. The main target of our compatibility efforts, Intel integrated graphics cards, don't render the application properly anyway due to faulty drivers, even with compatible 3.1 code.
  2. OpenGL 3.1 is very limiting and annoying to maintain.
  3. Newer systems either lack proper support for OpenGL 3.1 (such as M1 chips for MacOS), or they have a lot of issues with it (Newer Intel integrated graphics chips).

GbotHQ and others added 10 commits March 11, 2023 13:48
Improve OpenGL version error checking and remove redundant code.
Revert the switch from OpenGL 3.3 to OpenGL 3.1 on macOS. A driver bug on some macOS devices doesn't allow animeeffects to initialize an OpenGL 3.1 context.
Fix indentation.
Fix indentation.
@p-yukusai p-yukusai merged commit 00c4010 into AnimeEffectsDevs:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants