Fix: do not open changelog if not needed #556
Conversation
| // No need to show changelog if its was a browser update (and not extension update) | ||
| details.reason === "browser_update" || | ||
| // No need to show changelog if developer just reloaded the extension | ||
| (details.reason === "update" && |
There was a problem hiding this comment.
This is for when developer clicks "reload" button on chrome://extensions/.
| api.runtime.onInstalled.addListener((details) => { | ||
| if ( | ||
| // No need to show changelog if its was a browser update (and not extension update) | ||
| details.reason === "browser_update" || |
There was a problem hiding this comment.
This is the actual fix for #555.
|
Another problem - In future we might have the need to force the popup regardless of user's choice. For e.g. when
Here, we'll (in #556) have to comment out the code temporarily. My idea (in #537) behind using stored value was that we can override it programmatically from somewhere. I still don't have any plans on it's implementation to do this but it just seemed better to me than asking the browser & then adding conditions on it. Of course, if there's no good reason to use a stored value then this certainly a good way. 🙂 |
|
If #537 or #541 get rid of
You mean force opening changelog in a new tab (not popup)? Also, (in my personal opinion) I oppose anything that goes against explicit user choice. |
I understand. But just sometimes in some critical cases, we might need to. I view this (RYD's) option just like that. Yes, the user can disable almost all the notifications/popups (i.e. changelogs in the new tab) from RYD, but the critical ones. I don't know when we'll need this, and we can work on overriding when it's actually needed. |
To be honest, being able to paint the thumbs with colors is nice and great, but if I don't know there's this feature, I'm not disappointed. I would like the surprise of discovering new features by myself every now and then. But I don't want a new tab open every time there's an incremental update. A typo gets fixed, a link is updated, there's a new line between this sentence and the next. I don't give a damn, and I don't need you blasting this bubblegum to my face. For this fun project, I think the only critical message is our final goodbye, either when youtube decides to return dislikes itself, or we get a C&D. In either case, just use the simplest way and open a tab. Uninstall. Done. Move on with life. |
|
👍 |
|
Tanks |
Fixes #555 by checking extension installation details.