Add extension opt-in option to show update popup #541

cyrildtm · 2022-04-18T03:27:46Z

Add an opt-in option to display a new tab for changelog after each update.
Default is disabled, which means you won't see updates.
This comes after PR #537 with a temporary cherry pick. Tell me to rebase once that one is merged.
Improves #534
Part of #539

preparing for user option for showing changelog after update

part of Anarios#539

clean up unnecessary commented code Show changelog only on installation fixes Anarios#534 add changelog button in popup

cyrildtm · 2022-04-25T17:01:08Z

Added Do Not Merge tag. Reason: Use of extConfig in background script may cause race condition. The service worker is supposed to load or initialize user options, instead of using it.
This is an ongoing discussion. Keep this PR, may be adapted by #537. Cherry pick if convenient. Close when #537 is resolved.

Solve problem Anarios#1: Anarios#541 (comment) Use of extConfig in background script may cause race condition. The service worker is supposed to load or initialize user options, instead of using it. Solve problem Anarios#2: Anarios#537 (comment) Rare case # 1: without event listener or install reason check Extension updates. User notices opt-in option and switches on. Then closes browser. User opens youtube or whatever tab that has extension background script called. User receives an outdated update popup.

rephrase switch text

api is undefined

add scrollbar add hover fade-in animation

cyrildtm · 2022-04-26T23:49:44Z

Basically.... I saw v3.0 popup more than 20 times, just because I've got multiple accounts on multiple computers.

Anarios · 2022-04-27T00:05:17Z

3.0.1 is submited to the store for review.

Anarios · 2022-04-27T00:06:36Z

@cyrildtm, do you use chrome canary?

cyrildtm · 2022-04-27T00:14:45Z

@cyrildtm, do you use chrome canary?

Yes I'm on 103.0.5027.0 for developing this extension.
Now I'm making one more fix. Will explain in a second.

EDIT: If you meant why I've got so many popups, no I'm still on 100, and some of my computers still have 99. I don't update that often and I hate my tabs disappear. With v3.0, every time each computer and each account gets an update, I see a popup.

cyrildtm · 2022-04-27T00:19:17Z

An event listener for onInstalled is still a better solution. Here's an simple experiment:

in background js, add api.tabs.create({url: "about:blank"}); at the top level.

Wait until the service worker goes "inactive"; This can be easily observed when you have chrome://extensions/ open, while reading through this page explaining why service workers get terminated frequently.

Then, open extension settings and flip a switch. You will see a new tab.

Conclusion, background js (or service worker, whatever you call it) gets re-run frequently. It's quite a waste to read options. And why.

An event listener for onInstalled is still a better solution. Here's an simple experiment: in background js, add api.tabs.create({url: "about:blank"}); at the top level. Wait until the service worker goes "inactive"; This can be easily observed when you have chrome://extensions/ open, while reading through this page explaining why service workers get terminated frequently. Then, open extension settings and flip a switch. You will see a new tab. Conclusion, background js (or service worker, whatever you call it) gets re-run frequently. It's quite a waste to read options. And why.

cyrildtm · 2022-04-27T00:52:45Z

And ....

return-youtube-dislike/Extensions/combined/ryd.background.js

Line 81 in 2c39c09

details.reason === "update"

This version will never get a popup 😃

Anarios · 2022-04-27T07:45:43Z

And ....

return-youtube-dislike/Extensions/combined/ryd.background.js

Line 81 in 2c39c09

details.reason === "update"

This version will never get a popup 😃

It gets a popup only on install, just as intended for now.

Anarios · 2022-04-27T07:48:31Z

It's quite a waste to read options.
Is it an expensive operation, though? I thought that it costs almost nothing.

cyrildtm · 2022-04-27T11:12:48Z

It gets a popup only on install, just as intended for now.

I just noticed your words "for now". Okay, but we will need it to actually work in the future right?

it costs almost nothing.

A non-zero cost action is not nothing.
Currently we have seven options and therefore seven async gets to read the options, separately. One can justify "separately" with text clarity and async gets bunched anyway. This little feature causes another two async reads, which is +28%. Do it two million times. Not because we sacrifice efficiency for tidiness, but simply because we can. So yes, it is a waste.

Service worker gets killed and reinstated quite often, it's not like once every browser update. That's my understanding.

Anarios · 2022-04-27T11:58:01Z

Okay, but we will need it to actually work in the future right?

If there are ever changes big enough that everyone needs to be notified - then yeah. Right now I thought that showing it only on install is sufficient. I wanted to release the fix ASAP to not annoy people with Canary, so I went with the simplest solution of just disabling it.

This little feature causes another two async reads

Can be refactored into a single init function that reads all settings in one go.

Service worker gets killed and reinstated quite often

Every few minutes, if I'm not wrong.

cyrildtm · 2022-04-27T12:41:41Z

Refactoring can solve everything together.
Will do the following when I get ~~back~~ time

Step back with this PR
Make a new PR to refactor all initialize and handle functions. Make sure to keep text clarity. (I wanted to streamline handle as well since if the other is gone then this looks weird being left behind)
Re-prettify popup.html, make it consistent with main website's style. We need a scroll bar for the switches now.

cyrildtm · 2022-05-05T04:16:43Z

I just got a popup myself .. browser restart, no updates, extension is already 3.001.
.. and I just got another one, browser restart and update.

Will implement in a later PR This reverts commit 3e010be.

Let's fix this bug once for all. The code looks messy but let's hope it catches "most" of the rare cases users are complaining. Please keep the comments in source code to let people in the future know what's going on with this ugly logic.

cyrildtm · 2022-05-08T02:06:58Z

Let's fix this bug once for all. The code looks messy but let's hope it catches "most" of the rare cases users are complaining.

I went a bit pedantic in the comments in source code. Please keep them to let people in the future know what's going on with this ugly logic.

@sy-b @Anarios Please take a look and comment. Remember people complaining on Github or Chrome Web Store represent ~0.1% of all extension users, who represent ~0.1% of all Youtube users. (I don't use Discord so I have no idea) Let's get over this.

See my bug report #597

prettify popup add scrollbar add hover fade-in animation

add hover labels for select list label cherry pick Anarios#541 (prettify popup) prettify popup add scrollbar add hover fade-in animation Make popup scroll bar consistent with website use black/red color scheme and half-rounded shape

OnInstalledReason has slightly different content for Firefox and Chrome

More people use Chrome than Firefox. Check for Chrome update first. Reduce global warming.

- really allow popup on install (previously ineffective) - show debug messages in service worker console

In the bug-resolving case, we need to wait for the second layer of async storage get (for local) to finish before deciding to show the popup.

prettify popup add scrollbar add hover fade-in animation

Anarios · 2024-06-16T16:55:57Z

I believe there were no more complaints on popups, I will be closing this for now.

sy-b and others added 3 commits April 17, 2022 21:42

cherry pick PR Anarios#537

a2972b3

preparing for user option for showing changelog after update

clean up unnecessary commented code

95b66b4

Add user option to show changelog popup after update

b49bca3

part of Anarios#539

cyrildtm changed the title ~~Add extension option to show update popup~~ Add extension opt-in option to show update popup Apr 18, 2022

cyrildtm pushed a commit to cyrildtm/return-youtube-dislike that referenced this pull request Apr 19, 2022

cherry pick Anarios#541

a99410a

clean up unnecessary commented code Show changelog only on installation fixes Anarios#534 add changelog button in popup

This was referenced Apr 19, 2022

Add user option to re-format likes #549

Merged

Fix: do not open changelog if not needed #556

Merged

sy-b mentioned this pull request Apr 21, 2022

Show changelog only on installation #537

Merged

cyrildtm changed the title ~~Add extension opt-in option to show update popup~~ (Do not merge) Add extension opt-in option to show update popup Apr 25, 2022

cyrildtm added 5 commits April 26, 2022 18:06

Merge branch 'main' into extOptionShowUpdatePopup

3c4da99

Update popup.html

62823c2

rephrase switch text

Update popup.js

7ce3af3

api is undefined

prettify popup

3e010be

add scrollbar add hover fade-in animation

cyrildtm changed the title ~~(Do not merge) Add extension opt-in option to show update popup~~ Add extension opt-in option to show update popup Apr 26, 2022

Merge branch 'main' into extOptionShowUpdatePopup

e546470

cyrildtm marked this pull request as draft April 28, 2022 21:37

This was referenced May 1, 2022

(Bug): The "accessible" color scheme is not accessible for people with Tritanopia #552

Open

(Bug): Focus stealing on extension update to v3 #553

Closed

(Feature Request): Don't open Release Notes in a new tab after extension update #587

Open

cyrildtm mentioned this pull request May 8, 2022

(Feature Request): Please stop updating the extension every single day #589

Closed

2 tasks

cyrildtm added 2 commits May 7, 2022 19:44

Merge branch 'main' into extOptionShowUpdatePopup

c9d8769

Revert "prettify popup"

a178e86

Will implement in a later PR This reverts commit 3e010be.

cyrildtm mentioned this pull request May 8, 2022

(Bug): Huge security Issue between users on PC #569

Closed

Changelog popup: Use strict logic

461303c

Let's fix this bug once for all. The code looks messy but let's hope it catches "most" of the rare cases users are complaining. Please keep the comments in source code to let people in the future know what's going on with this ugly logic.

cyrildtm marked this pull request as ready for review May 8, 2022 02:07

cyrildtm added a commit to cyrildtm/return-youtube-dislike that referenced this pull request May 8, 2022

cherry pick Anarios#541 (prettify popup)

ef8b7c0

prettify popup add scrollbar add hover fade-in animation

cyrildtm added 2 commits May 10, 2022 11:29

filter out more browser update events

4b6ceb7

OnInstalledReason has slightly different content for Firefox and Chrome

save energy

3bf60df

More people use Chrome than Firefox. Check for Chrome update first. Reduce global warming.

cyrildtm mentioned this pull request May 12, 2022

(Bug): Changelog popup repeats every day #597

Closed

cyrildtm added 4 commits May 12, 2022 14:13

allow popup on first install

312b697

improve function

c3a95aa

- really allow popup on install (previously ineffective) - show debug messages in service worker console

fix indent

1e1ea15

wait for async storage get

cd71343

In the bug-resolving case, we need to wait for the second layer of async storage get (for local) to finish before deciding to show the popup.

cyrildtm mentioned this pull request Jun 16, 2022

Handle onInstalled.reason "chrome_update" #649

Merged

bershanskiy mentioned this pull request Jun 16, 2022

Inconsistency: browser.runtime.OnInstalledReason w3c/webextensions#230

Open

gergelypap pushed a commit to gergelypap/return-youtube-dislike that referenced this pull request Sep 28, 2023

cherry pick Anarios#541 (prettify popup)

cb5afd8

prettify popup add scrollbar add hover fade-in animation

Anarios closed this Jun 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add extension opt-in option to show update popup #541

Add extension opt-in option to show update popup #541

cyrildtm commented Apr 18, 2022

cyrildtm commented Apr 25, 2022

cyrildtm commented Apr 26, 2022 •

edited

Loading

Anarios commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022 •

edited

Loading

cyrildtm commented Apr 27, 2022

cyrildtm commented Apr 27, 2022

Anarios commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022 •

edited

Loading

cyrildtm commented May 5, 2022 •

edited

Loading

cyrildtm commented May 8, 2022 •

edited

Loading

Anarios commented Jun 16, 2024

Add extension opt-in option to show update popup #541

Add extension opt-in option to show update popup #541

Conversation

cyrildtm commented Apr 18, 2022

cyrildtm commented Apr 25, 2022

cyrildtm commented Apr 26, 2022 • edited Loading

Anarios commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022 • edited Loading

cyrildtm commented Apr 27, 2022

cyrildtm commented Apr 27, 2022

Anarios commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022

Anarios commented Apr 27, 2022

cyrildtm commented Apr 27, 2022 • edited Loading

cyrildtm commented May 5, 2022 • edited Loading

cyrildtm commented May 8, 2022 • edited Loading

Anarios commented Jun 16, 2024

cyrildtm commented Apr 26, 2022 •

edited

Loading

cyrildtm commented Apr 27, 2022 •

edited

Loading

cyrildtm commented Apr 27, 2022 •

edited

Loading

cyrildtm commented May 5, 2022 •

edited

Loading

cyrildtm commented May 8, 2022 •

edited

Loading