Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace equals Regions on ranging beacons requests #991

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Replace equals Regions on ranging beacons requests #991

merged 2 commits into from
Apr 5, 2021

Conversation

Vandalko
Copy link
Contributor

@Vandalko Vandalko commented Jul 24, 2020 •
edited
Loading

Closes #990

Long-running app may call "startRangingBeaconsInRegion" a significant number of times.
There's no internal check if such range is already present resulting in unlimited array growth.

davidgyoung
davidgyoung approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@davidgyoung davidgyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late merge. This is a great change, thank you, @Vandalko

@davidgyoung davidgyoung merged commit 4302224 into AltBeacon:master Apr 5, 2021
@Vandalko Vandalko deleted the ranging-regions branch April 5, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgyoung davidgyoung davidgyoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

startRangingBeaconsInRegion should check range ID
2 participants
@Vandalko @davidgyoung