Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startRangingBeaconsInRegion should check range ID #990

Closed
Vandalko opened this issue Jul 24, 2020 · 1 comment · Fixed by #991
Closed

startRangingBeaconsInRegion should check range ID #990

Vandalko opened this issue Jul 24, 2020 · 1 comment · Fixed by #991

Comments

@Vandalko
Copy link
Contributor

Long-running app may call "startRangingBeaconsInRegion" a significant number of times.
There's no internal check if such range is already present resulting in unlimited array growth.

I think the correct behavior should be to replace the existing (same ID) region.

@davidgyoung
Copy link
Member

@Vandalko. I did a quick check and you are absolutely right. I am surprised that it has been this way for so long! This does not seem to have caused any problem reports that I am aware of, but it would still be good to fix.

I'd welcome a pull request if you are up for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants