Correct pom for JUnit tests & test dir fixes #8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. The failing tests in |
|
Hi, @Alonso-del-Arte, Thanks for the merge, all is well, and this PR has been accepted fore Hacktoberfest. Hopefully we will meet again, Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Alonso-del-Arte,
The test directory was moved to src, and the tests were moved to src/test/java.
Dependencies section was added to pom.xml, and JUnit was added as a dependency.
Ran the tests and some from bankaccounts are failing.
Please do check and advise on this PR that fixes #8.
If any change is required, please do let me know.
I am glad this is my last PR for Hacktoberfest 2022.
Cheers
note: I have never used JUnit, and used How to run unit test with Maven as a guide