IVS_GetSetQCForSweep: Add convenience function for querying Set QC passed/failed state #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed/failed state
timjarsky
reviewed
Mar 28, 2020
| /// @brief Return the Set QC passed/failed state for the given sweep | ||
| /// | ||
| /// @return 1 if passed, 0 if not (or not yet) and | ||
| /// asserts out on all other errors. |
There was a problem hiding this comment.
@t-b Do we want assertions in this function? I'm reluctant to have a call from the work sequence engine turn off whatever the user is doing at that time. What about returning an error message to the caller?
There was a problem hiding this comment.
Calling a function via zeromq XOP which asserts out does not stop anything running in IP. So switchting to just return errors is giving only less clutter in the history.
timjarsky
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #410.
Functionality requested by @aleonlein.