Skip to content

Radius Rounding Bug #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascibisz merged 3 commits into from
Nov 13, 2025
Merged

Radius Rounding Bug #153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8632c4c
round value on sliders
ascibisz Nov 10, 2025
feb73cf
prevent people from typing non-numbers into the text box
ascibisz Nov 11, 2025
0a3328b
limit figure in maxVal
ascibisz Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/InputSwitch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const InputSwitch = (props: InputSwitchProps): JSX.Element => {
}
if (typeof value == "number") {
value = value * conversion;
value = Number(value.toFixed(4));
}
return value;
}, [getCurrentValue, id, min, conversion, dataType]);
Expand All @@ -67,6 +68,7 @@ const InputSwitch = (props: InputSwitchProps): JSX.Element => {
if (typeof value === "number") {
// Convert back to original units for updating recipe object
value = value / conversion;
value = Number(value.toFixed(4));
}
updateRecipeObj(selectedRecipeId, { [id]: value });
};
Expand All @@ -76,7 +78,8 @@ const InputSwitch = (props: InputSwitchProps): JSX.Element => {
const numericValue =
typeof value === "number" ? value : Number(value) || 0;
const step = dataType === "integer" ? 1 : 0.01;
const maxValue = (max ?? 1) * conversion;
let maxValue = (max ?? 1) * conversion;
maxValue = Number(maxValue.toFixed(4));

return (
<div className="input-switch">
Expand All @@ -100,6 +103,7 @@ const InputSwitch = (props: InputSwitchProps): JSX.Element => {
style={{ margin: "0 6px" }}
value={numericValue}
onChange={handleInputChange}
type="number"
Copy link
Contributor

@rugeli rugeli Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type="number"
type="number"
tooltip={{ formatter: (value) => value?.toFixed(2) }}

Copy link
Contributor Author

@ascibisz ascibisz Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line actually meant for the Slider, rather than the InputNumber?

Copy link
Contributor Author

@ascibisz ascibisz Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the root of the issue here is that we're rounding off the values, but not the maxValues, so we're getting an issue where we're trying to allow the user to input the max of 0.16199999999, but then we round that to 0.162 which is above the max.

I'll add the same rounding to the maxValue and that will solve this issue!

Copy link
Contributor

@rugeli rugeli Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! just tested again and it worked well!

/>
{unit && <span>{unit}</span>}
</div>
Expand Down