Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
rugeli
reviewed
Nov 11, 2025
Contributor
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
looks like the tooltip in the screenshot is still a bit off, should we tweak the formatting?(I'll add a comment at the spot)
rugeli
reviewed
Nov 11, 2025
| style={{ margin: "0 6px" }} | ||
| value={numericValue} | ||
| onChange={handleInputChange} | ||
| type="number" |
Contributor
There was a problem hiding this comment.
Suggested change
| type="number" | |
| type="number" | |
| tooltip={{ formatter: (value) => value?.toFixed(2) }} |
Contributor
Author
There was a problem hiding this comment.
Is this line actually meant for the Slider, rather than the InputNumber?
Contributor
Author
There was a problem hiding this comment.
I think the root of the issue here is that we're rounding off the values, but not the maxValues, so we're getting an issue where we're trying to allow the user to input the max of 0.16199999999, but then we round that to 0.162 which is above the max.
I'll add the same rounding to the maxValue and that will solve this issue!
Contributor
There was a problem hiding this comment.
Nice fix! just tested again and it worked well!
rugeli
approved these changes
Nov 12, 2025
ascibisz
force-pushed
the
bug/radii-rounding
branch
from
07a3388 to
0a3328b
Compare
meganrm
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rounding was behaving weirdly when you typed in a value see ticket
Solution
Since the radius is converted from micrometers in the input field to voxels in the recipe JSON, we getting some floats back with a lot of figures after the decimal point. Simply clamping the number of figures and rounding seemed to fix the problem.
I also added
type="number", which just prevents people from entering non-numbers into the little input box next to the slider