Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds on github actions are slow #702

Closed
X-sam opened this issue Sep 8, 2024 · 2 comments · Fixed by #705
Closed

Builds on github actions are slow #702

X-sam opened this issue Sep 8, 2024 · 2 comments · Fixed by #705
Labels
bug Devops

Comments

@X-sam
Copy link
Member

X-sam commented Sep 8, 2024

Apparently we need to update the version of cache action we use.
jonathanperret added a commit to jonathanperret/ayab-desktop that referenced this issue Sep 8, 2024
@jonathanperret
Upgrade actions/cache from v3 to v4
eb76772 
Fixes build slowness (AllYarnsAreBeautiful#702).

Also fixes fail-on-cache-miss having no effect, see
actions/cache#1327
@jonathanperret jonathanperret mentioned this issue Sep 8, 2024
Merged
dl1com pushed a commit that referenced this issue Sep 9, 2024
@jonathanperret @dl1com
Upgrade actions/cache from v3 to v4
6f80a2a 
Fixes build slowness (#702).

Also fixes fail-on-cache-miss having no effect, see
actions/cache#1327
@dl1com
Copy link
Contributor

dl1com commented Sep 9, 2024

Missed to merge the PR before triggering the build for 1.0.0-build1 😓 But now it's merged and will be fixed for upcoming builds...

@jonathanperret
Copy link
Contributor

Missed to merge the PR before triggering the build for 1.0.0-build1 😓 But now it's merged and will be fixed for upcoming builds...

No worries! It will make future builds cleaner and that's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade GitHub actions to current supported versions jonathanperret/ayab-desktop
3 participants
@jonathanperret @dl1com @X-sam