Upgrade GitHub actions to current supported versions #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build slowness (AllYarnsAreBeautiful#702). Also fixes fail-on-cache-miss having no effect, see actions/cache#1327
WalkthroughThe pull request involves updates to GitHub Actions workflow configurations by upgrading various action versions. Notably, the Changes
Sequence Diagram(s)sequenceDiagram
participant A as User
participant B as GitHub Actions
participant C as Python Environment
participant D as Build Process
A->>B: Trigger Workflow
B->>C: Setup Python Environment (v5)
B->>D: Start Build Process
D-->>B: Build Completed
B-->>A: Workflow Result
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
dl1com
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702 by upgrading
actions/cachefrom v3 to v4. In extreme cases like https://github.com/AllYarnsAreBeautiful/ayab-desktop/actions/runs/10762969747/attempts/1 this should cut build time from 30 minutes down to less than 10.This PR also upgrades
actions/checkoutfrom v3 to v4,actions/setup-pythonfrom v4 to v5,actions/upload-artifactfrom v3 to v4, andDenverCoder1/doxygen-github-pages-actionfrom v1.3.0 to v1.3.1, which gets rid of warnings that we use old actions requiring Node 16.There should be no changes in behavior — if something is broken by these upgrades it should show up pretty quickly when doing a build. Here is a full build I made from this branch — the macOS failure is not new and is being investigated separately (and merging this PR will make it faster to investigate).