PWGHF: fix task for efficiency calculation checking daughter production process #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZFederica
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#5748
fcatalan92
requested changes
Apr 22, 2024
Collaborator
There was a problem hiding this comment.
Hi @ZFederica, I made a few minor comments. On top of them, I have a question: why are you doing these checks "manually" and you are not using the functions provided in RecoDecay.h? After the fixes in #5407, they should be enough for the job.
Contributor
Author
|
Hi @fcatalan92, the check on the daughters (pdg code and process) are necessary because I need to check on some of the daughter properties for the different steps of efficiency calculation. I will remove the continue statement. |
fcatalan92
approved these changes
Apr 22, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
…on process (AliceO2Group#5748) * Fix eff task * Fix cast * Fix error * Fix * Remove comments * Remove include * Please consider the following formatting changes * Remove continue * Remove check on nr dau --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
…on process (AliceO2Group#5748) * Fix eff task * Fix cast * Fix error * Fix * Remove comments * Remove include * Please consider the following formatting changes * Remove continue * Remove check on nr dau --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix efficiency calculation taking into account the production process of the daughters