Common: RecoDecay: Consider only particles coming from decay process when matching #5407

ZFederica · 2024-03-28T15:56:46Z

Check the production process of particles when doing the MC matching (both rec and gen) so that only particles coming from the decay are taken into account. This is optional and can be controlled using the parameter checkProcess, which is by default false (so the default behaviour is not changed wrt the current version of O2Physics).
In particular the check on the process is done using the function getProcess(), that returns kPDecay for particles produced in a decay this function. This check is implemented inside getMatchedMcRec and isMatchedMcGen. Inside these functions the checks on the number of daughters have been removed because they do not allow to properly take into account only the desiderd daughters.

ZFederica · 2024-03-28T15:57:03Z

@fgrosa

Please consider the following formatting changes to AliceO2Group#5407

alibuild · 2024-03-28T19:22:30Z

Error while checking build/O2Physics/o2 for 196b336 at 2024-03-28 20:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:60: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:737:78: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:53: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/5407-slc7_x86-64/0/Common/Core/RecoDecay.h:862:71: error: expected primary-expression before ')' token
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-03-28T20:22:18Z

Error while checking build/O2Physics/o2 for 8311b7e at 2024-03-28 21:22:

## sw/BUILD/O2Physics-latest/log
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<aod::BCs, aod::Timestamps> >, Table<Index<0, -1>, RunNumber, GlobalBC, TriggerMask, InputMask>, Table<Timestamp> >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<aod::BCs, aod::Timestamps> >, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::aod::timestamp::Timestamp> >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<TracksExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Energy<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<1> > > >, TracksExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Energy<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<1> > >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::TracksExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> > > >, o2::aod::TracksExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> > >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<TracksIUExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<2> > > >, TracksIUExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<2> > >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::TracksIUExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<2> > > >, o2::aod::TracksIUExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<2> > >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<TracksCovExtension, Table<SigmaY, SigmaZ, SigmaSnp, SigmaTgl, Sigma1Pt, RhoZY, RhoSnpY, RhoSnpZ, RhoTglY, RhoTglZ, RhoTglSnp, Rho1PtY, Rho1PtZ, Rho1PtSnp, Rho1PtTgl, Marker<1> > > >, TracksCovExtension, Table<SigmaY, SigmaZ, SigmaSnp, SigmaTgl, Sigma1Pt, RhoZY, RhoSnpY, RhoSnpZ, RhoTglY, RhoTglZ, RhoTglSnp, Rho1PtY, Rho1PtZ, Rho1PtSnp, Rho1PtTgl, Marker<1> > >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::TracksCovExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<1> > > >, o2::aod::TracksCovExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<1> > >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<TracksCovIUExtension, Table<SigmaY, SigmaZ, SigmaSnp, SigmaTgl, Sigma1Pt, RhoZY, RhoSnpY, RhoSnpZ, RhoTglY, RhoTglZ, RhoTglSnp, Rho1PtY, Rho1PtZ, Rho1PtSnp, Rho1PtTgl, Marker<2> > > >, TracksCovIUExtension, Table<SigmaY, SigmaZ, SigmaSnp, SigmaTgl, Sigma1Pt, RhoZY, RhoSnpY, RhoSnpZ, RhoTglY, RhoTglZ, RhoTglSnp, Rho1PtY, Rho1PtZ, Rho1PtSnp, Rho1PtTgl, Marker<2> > >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::TracksCovIUExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<2> > > >, o2::aod::TracksCovIUExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<2> > >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<TracksExtra_001Extension, Table<TPCInnerParam, Flags, ITSClusterSizes, TPCNClsFindable, TPCNClsFindableMinusFound, TPCNClsFindableMinusCrossedRows, TPCNClsShared, TRDPattern, ITSChi2NCl, TPCChi2NCl, TRDChi2, TOFChi2, TPCSignal, TRDSignal, Length, TOFExpMom, PIDForTracking<Flags>, IsPVContributor<Flags>, HasITS<DetectorMap>, HasTPC<DetectorMap>, HasTRD<DetectorMap>, HasTOF<DetectorMap>, TPCNClsFound<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCNClsCrossedRows<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, ITSClusterMap<ITSClusterSizes>, ITSNCls<ITSClusterSizes>, ITSNClsInnerBarrel<ITSClusterSizes>, ITSClsSizeInLayer<ITSClusterSizes>, TPCCrossedRowsOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, TPCFoundOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCFractionSharedCls<TPCNClsShared, TPCNClsFindable, TPCNClsFindableMinusFound>, TrackEtaEMCAL, TrackPhiEMCAL, TrackTime, TrackTimeRes> > >, TracksExtra_001Extension, Table<TPCInnerParam, Flags, ITSClusterSizes, TPCNClsFindable, TPCNClsFindableMinusFound, TPCNClsFindableMinusCrossedRows, TPCNClsShared, TRDPattern, ITSChi2NCl, TPCChi2NCl, TRDChi2, TOFChi2, TPCSignal, TRDSignal, Length, TOFExpMom, PIDForTracking<Flags>, IsPVContributor<Flags>, HasITS<DetectorMap>, HasTPC<DetectorMap>, HasTRD<DetectorMap>, HasTOF<DetectorMap>, TPCNClsFound<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCNClsCrossedRows<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, ITSClusterMap<ITSClusterSizes>, ITSNCls<ITSClusterSizes>, ITSNClsInnerBarrel<ITSClusterSizes>, ITSClsSizeInLayer<ITSClusterSizes>, TPCCrossedRowsOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, TPCFoundOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCFractionSharedCls<TPCNClsShared, TPCNClsFindable, TPCNClsFindableMinusFound>, TrackEtaEMCAL, TrackPhiEMCAL, TrackTime, TrackTimeRes> >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::TracksExtra_001Extension, o2::soa::Table<o2::aod::track::TPCInnerParam, o2::aod::track::Flags, o2::aod::track::ITSClusterSizes, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound, o2::aod::track::TPCNClsFindableMinusCrossedRows, o2::aod::track::TPCNClsShared, o2::aod::track::TRDPattern, o2::aod::track::ITSChi2NCl, o2::aod::track::TPCChi2NCl, o2::aod::track::TRDChi2, o2::aod::track::TOFChi2, o2::aod::track::TPCSignal, o2::aod::track::TRDSignal, o2::aod::track::Length, o2::aod::track::TOFExpMom, o2::aod::track::PIDForTracking<o2::aod::track::Flags>, o2::aod::track::IsPVContributor<o2::aod::track::Flags>, o2::aod::track::HasITS<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTPC<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTRD<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTOF<o2::aod::track::v001::DetectorMap>, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::v001::ITSClusterMap<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNCls<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNClsInnerBarrel<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSClsSizeInLayer<o2::aod::track::ITSClusterSizes>, o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::TPCFoundOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCFractionSharedCls<o2::aod::track::TPCNClsShared, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TrackEtaEMCAL, o2::aod::track::TrackPhiEMCAL, o2::aod::track::TrackTime, o2::aod::track::TrackTimeRes> > >, o2::aod::TracksExtra_001Extension, o2::soa::Table<o2::aod::track::TPCInnerParam, o2::aod::track::Flags, o2::aod::track::ITSClusterSizes, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound, o2::aod::track::TPCNClsFindableMinusCrossedRows, o2::aod::track::TPCNClsShared, o2::aod::track::TRDPattern, o2::aod::track::ITSChi2NCl, o2::aod::track::TPCChi2NCl, o2::aod::track::TRDChi2, o2::aod::track::TOFChi2, o2::aod::track::TPCSignal, o2::aod::track::TRDSignal, o2::aod::track::Length, o2::aod::track::TOFExpMom, o2::aod::track::PIDForTracking<o2::aod::track::Flags>, o2::aod::track::IsPVContributor<o2::aod::track::Flags>, o2::aod::track::HasITS<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTPC<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTRD<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTOF<o2::aod::track::v001::DetectorMap>, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::v001::ITSClusterMap<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNCls<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNClsInnerBarrel<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSClsSizeInLayer<o2::aod::track::ITSClusterSizes>, o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::TPCFoundOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCFractionSharedCls<o2::aod::track::TPCNClsShared, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TrackEtaEMCAL, o2::aod::track::TrackPhiEMCAL, o2::aod::track::TrackTime, o2::aod::track::TrackTimeRes> >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<aod::Tracks, aod::TracksExtra> >, TracksExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Energy<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<1> >, TracksExtra_001Extension, Table<TPCInnerParam, Flags, ITSClusterSizes, TPCNClsFindable, TPCNClsFindableMinusFound, TPCNClsFindableMinusCrossedRows, TPCNClsShared, TRDPattern, ITSChi2NCl, TPCChi2NCl, TRDChi2, TOFChi2, TPCSignal, TRDSignal, Length, TOFExpMom, PIDForTracking<Flags>, IsPVContributor<Flags>, HasITS<DetectorMap>, HasTPC<DetectorMap>, HasTRD<DetectorMap>, HasTOF<DetectorMap>, TPCNClsFound<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCNClsCrossedRows<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, ITSClusterMap<ITSClusterSizes>, ITSNCls<ITSClusterSizes>, ITSNClsInnerBarrel<ITSClusterSizes>, ITSClsSizeInLayer<ITSClusterSizes>, TPCCrossedRowsOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, TPCFoundOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCFractionSharedCls<TPCNClsShared, TPCNClsFindable, TPCNClsFindableMinusFound>, TrackEtaEMCAL, TrackPhiEMCAL, TrackTime, TrackTimeRes> >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<aod::Tracks, aod::TracksExtra> >, o2::aod::TracksExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> >, o2::aod::TracksExtra_001Extension, o2::soa::Table<o2::aod::track::TPCInnerParam, o2::aod::track::Flags, o2::aod::track::ITSClusterSizes, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound, o2::aod::track::TPCNClsFindableMinusCrossedRows, o2::aod::track::TPCNClsShared, o2::aod::track::TRDPattern, o2::aod::track::ITSChi2NCl, o2::aod::track::TPCChi2NCl, o2::aod::track::TRDChi2, o2::aod::track::TOFChi2, o2::aod::track::TPCSignal, o2::aod::track::TRDSignal, o2::aod::track::Length, o2::aod::track::TOFExpMom, o2::aod::track::PIDForTracking<o2::aod::track::Flags>, o2::aod::track::IsPVContributor<o2::aod::track::Flags>, o2::aod::track::HasITS<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTPC<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTRD<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTOF<o2::aod::track::v001::DetectorMap>, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::v001::ITSClusterMap<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNCls<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNClsInnerBarrel<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSClsSizeInLayer<o2::aod::track::ITSClusterSizes>, o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::TPCFoundOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCFractionSharedCls<o2::aod::track::TPCNClsShared, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TrackEtaEMCAL, o2::aod::track::TrackPhiEMCAL, o2::aod::track::TrackTime, o2::aod::track::TrackTimeRes> >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<aod::Tracks, aod::TracksCov, aod::TracksExtra> >, TracksExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, Energy<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<1> >, TracksCovExtension, Table<SigmaY, SigmaZ, SigmaSnp, SigmaTgl, Sigma1Pt, RhoZY, RhoSnpY, RhoSnpZ, RhoTglY, RhoTglZ, RhoTglSnp, Rho1PtY, Rho1PtZ, Rho1PtSnp, Rho1PtTgl, Marker<1> >, TracksExtra_001Extension, Table<TPCInnerParam, Flags, ITSClusterSizes, TPCNClsFindable, TPCNClsFindableMinusFound, TPCNClsFindableMinusCrossedRows, TPCNClsShared, TRDPattern, ITSChi2NCl, TPCChi2NCl, TRDChi2, TOFChi2, TPCSignal, TRDSignal, Length, TOFExpMom, PIDForTracking<Flags>, IsPVContributor<Flags>, HasITS<DetectorMap>, HasTPC<DetectorMap>, HasTRD<DetectorMap>, HasTOF<DetectorMap>, TPCNClsFound<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCNClsCrossedRows<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, ITSClusterMap<ITSClusterSizes>, ITSNCls<ITSClusterSizes>, ITSNClsInnerBarrel<ITSClusterSizes>, ITSClsSizeInLayer<ITSClusterSizes>, TPCCrossedRowsOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, TPCFoundOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCFractionSharedCls<TPCNClsShared, TPCNClsFindable, TPCNClsFindableMinusFound>, TrackEtaEMCAL, TrackPhiEMCAL, TrackTime, TrackTimeRes> >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<aod::Tracks, aod::TracksCov, aod::TracksExtra> >, o2::aod::TracksExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> >, o2::aod::TracksCovExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<1> >, o2::aod::TracksExtra_001Extension, o2::soa::Table<o2::aod::track::TPCInnerParam, o2::aod::track::Flags, o2::aod::track::ITSClusterSizes, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound, o2::aod::track::TPCNClsFindableMinusCrossedRows, o2::aod::track::TPCNClsShared, o2::aod::track::TRDPattern, o2::aod::track::ITSChi2NCl, o2::aod::track::TPCChi2NCl, o2::aod::track::TRDChi2, o2::aod::track::TOFChi2, o2::aod::track::TPCSignal, o2::aod::track::TRDSignal, o2::aod::track::Length, o2::aod::track::TOFExpMom, o2::aod::track::PIDForTracking<o2::aod::track::Flags>, o2::aod::track::IsPVContributor<o2::aod::track::Flags>, o2::aod::track::HasITS<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTPC<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTRD<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTOF<o2::aod::track::v001::DetectorMap>, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::v001::ITSClusterMap<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNCls<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNClsInnerBarrel<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSClsSizeInLayer<o2::aod::track::ITSClusterSizes>, o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::TPCFoundOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCFractionSharedCls<o2::aod::track::TPCNClsShared, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TrackEtaEMCAL, o2::aod::track::TrackPhiEMCAL, o2::aod::track::TrackTime, o2::aod::track::TrackTimeRes> >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<MFTTracks_001Extension, Table<Index<0, -1>, CollisionId, X, Y, Z, Phi, Tgl, Signed1Pt, NClusters<MFTClusterSizesAndTrackFlags>, MFTClusterSizesAndTrackFlags, IsCA<MFTClusterSizesAndTrackFlags>, Px<Pt, Phi>, Py<Pt, Phi>, Pz<Pt, Tgl>, Sign<Signed1Pt>, Chi2, TrackTime, TrackTimeRes> > >, MFTTracks_001Extension, Table<Index<0, -1>, CollisionId, X, Y, Z, Phi, Tgl, Signed1Pt, NClusters<MFTClusterSizesAndTrackFlags>, MFTClusterSizesAndTrackFlags, IsCA<MFTClusterSizesAndTrackFlags>, Px<Pt, Phi>, Py<Pt, Phi>, Pz<Pt, Tgl>, Sign<Signed1Pt>, Chi2, TrackTime, TrackTimeRes> >' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<o2::aod::MFTTracks_001Extension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::fwdtrack::CollisionId, o2::aod::fwdtrack::X, o2::aod::fwdtrack::Y, o2::aod::fwdtrack::Z, o2::aod::fwdtrack::Phi, o2::aod::fwdtrack::Tgl, o2::aod::fwdtrack::Signed1Pt, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>, o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags, o2::aod::fwdtrack::IsCA<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>, o2::aod::fwdtrack::Px<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Phi>, o2::aod::fwdtrack::Py<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Phi>, o2::aod::fwdtrack::Pz<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Tgl>, o2::aod::fwdtrack::Sign<o2::aod::fwdtrack::Signed1Pt>, o2::aod::fwdtrack::Chi2, o2::aod::fwdtrack::TrackTime, o2::aod::fwdtrack::TrackTimeRes> > >, o2::aod::MFTTracks_001Extension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::fwdtrack::CollisionId, o2::aod::fwdtrack::X, o2::aod::fwdtrack::Y, o2::aod::fwdtrack::Z, o2::aod::fwdtrack::Phi, o2::aod::fwdtrack::Tgl, o2::aod::fwdtrack::Signed1Pt, o2::aod::fwdtrack::v001::NClusters<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>, o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags, o2::aod::fwdtrack::IsCA<o2::aod::fwdtrack::MFTClusterSizesAndTrackFlags>, o2::aod::fwdtrack::Px<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Phi>, o2::aod::fwdtrack::Py<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Phi>, o2::aod::fwdtrack::Pz<o2::aod::fwdtrack::Pt, o2::aod::fwdtrack::Tgl>, o2::aod::fwdtrack::Sign<o2::aod::fwdtrack::Signed1Pt>, o2::aod::fwdtrack::Chi2, o2::aod::fwdtrack::TrackTime, o2::aod::fwdtrack::TrackTimeRes> >')
/sw/slc7_x86-64/O2/daily-20240328-0100-local3/include/Framework/ASoA.h:2842:29: error: base class has incomplete type
Error: /sw/slc7_x86-64/ROOT/v6-30-01-alice4-local2/bin/rootcling: compilation failure (/sw/BUILD/078cafbd971ab885b5486a26fce8fb0e9a9063e5/O2Physics/PWGDQ/Core/G__O2PhysicsPWGDQCorea77bf24e46_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2024-04-02T17:16:07Z

Hi @ZFederica , please give more details about your suggested changes and why they are needed. This is a core header so we should be very careful what we add and change. For example, we should not need the analysis data model header.
In general, please compile your code locally first before making a PR ready for review.

Common/Core/RecoDecay.h

fgrosa · 2024-04-03T10:07:19Z

Hi @ZFederica , please give more details about your suggested changes and why they are needed. This is a core header so we should be very careful what we add and change. For example, we should not need the analysis data model header. In general, please compile your code locally first before making a PR ready for review.

Hi @vkucera, about the reason for this development (not the technical implementation that I still did not check indeed), is that because of interactions with materials, we have in the Monte Carlo electrons and nuclei that are "daughters" of strange particles, like Xi and Omegas (this is because these particles are decayed by GEANT, that simulates correctly also the interaction with the material). If not added the check of the process that generated these particles, they are counted as decay daughters, and true signals get rejected (while they should not be).

Common/Core/RecoDecay.h

vkucera

The correct place for checking getProcess is inside getDaughters. That is the purpose of that function. It should not be needed to check it anywhere else.
The check should be done if (checkProcess) which should be false by default.
You should not remove any existing checks. You can skip the check on too many direct daughters if (checkProcess).

Common/Core/RecoDecay.h

ZFederica · 2024-04-11T15:10:03Z

Moving the check inside getDaughters did not work, the build did not fail but I also ended up with 0 candidates matched. If that function is not modified, it also does not make sense to leave the checks on the number of daughters (because I would count "daughters" not coming from the decay and there would be a mismatch in the numbers)

vkucera · 2024-04-11T15:22:24Z

I would try this inside getDaughters:

    // If the particle is neither the original particle nor coming from a decay, we do nothing and exit.
    if (checkProcess && stage != 0 && particle.getProcess() != TMCProcess::kPDecay) {
      return;
    }

ZFederica · 2024-04-12T08:12:37Z

I tried to add these exact lines just before bool isFinal = false; and again I ended up with 0 candidates matched

vkucera · 2024-04-12T08:48:03Z

Does everything work as before (in master) with checkProcess = false?

Can you add this before the return statement and see for which particles it fails?

LOGF(warn, "PDG code = %d, process code = %d", particle.pdgCode(), particle.getProcess());

Please consider the following formatting changes to AliceO2Group#5407

vkucera

Thanks @ZFederica , the current version looks very good.
Please see my suggestions.

Common/Core/RecoDecay.h

Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Please consider the following formatting changes to AliceO2Group#5407

vkucera

Thanks @ZFederica , it looks good to me now.

ZFederica · 2024-04-15T12:55:13Z

Perfect, thanks @vkucera

Common/Core/RecoDecay.h

vkucera · 2024-04-18T07:40:55Z

@ddobrigk This is ready for merging.

…when matching (AliceO2Group#5407) * Consider only particles coming from decay process when matching * Please consider the following formatting changes * Move a check * Please consider the following formatting changes * Fix a process check * Remove comment * Add template keyword * Fix namespace * Add missing include * Remove header * Remove hard-coded table * Re-arrange * Remove comment * Please consider the following formatting changes * Change cast * Implement requested changes * Remove TMCProcess * Change implementation * Clean * Final changes * Please consider the following formatting changes * Clean * Requested changes * Latest implementation * Please consider the following formatting changes * Update Common/Core/RecoDecay.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Implement requested changes * Please consider the following formatting changes * Change doc order --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Consider only particles coming from decay process when matching

904f8c8

ZFederica requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners March 28, 2024 15:56

alibuild and others added 10 commits March 28, 2024 15:57

Please consider the following formatting changes

446493e

Merge pull request #69 from alibuild/alibot-cleanup-5407

f2965bd

Please consider the following formatting changes to AliceO2Group#5407

Move a check

e46fb24

Please consider the following formatting changes

bf036a5

Merge pull request #70 from alibuild/alibot-cleanup-5407

33aa9ff

Please consider the following formatting changes to AliceO2Group#5407

Fix a process check

d21d0a5

Remove comment

196b336

Add template keyword

dd37787

Fix namespace

17a7ea5

Add missing include

8311b7e

vkucera marked this pull request as draft April 2, 2024 17:13

vkucera changed the title ~~COMMON: consider only particles coming from decay process when matching~~ Common: RecoDecay: Consider only particles coming from decay process when matching Apr 2, 2024

vkucera requested changes Apr 2, 2024

View reviewed changes

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

vkucera reviewed Apr 5, 2024

View reviewed changes

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

vkucera reviewed Apr 5, 2024

View reviewed changes

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

vkucera reviewed Apr 5, 2024

View reviewed changes

Common/Core/RecoDecay.h Outdated Show resolved Hide resolved

ZFederica added 2 commits April 8, 2024 09:55

Remove header

44a90a4

Remove hard-coded table

6744029

vkucera marked this pull request as draft April 11, 2024 14:51

vkucera requested changes Apr 11, 2024

View reviewed changes

ZFederica and others added 5 commits April 12, 2024 11:10

Clean

99d664f

Requested changes

4972243

Latest implementation

f1e0ecf

Please consider the following formatting changes

b241254

Merge pull request #73 from alibuild/alibot-cleanup-5407

cc82aee

Please consider the following formatting changes to AliceO2Group#5407

ZFederica marked this pull request as ready for review April 12, 2024 18:37

ZFederica requested a review from hahassan7 as a code owner April 12, 2024 18:37

vkucera requested changes Apr 15, 2024

View reviewed changes

ZFederica and others added 5 commits April 15, 2024 13:47

Update Common/Core/RecoDecay.h

7c0d654

Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

Implement requested changes

db33b8e

Please consider the following formatting changes

fffd20d

Merge pull request #74 from alibuild/alibot-cleanup-5407

e046b18

Please consider the following formatting changes to AliceO2Group#5407

Change doc order

a1f06a8

vkucera approved these changes Apr 15, 2024

View reviewed changes

fcatalan92 reviewed Apr 15, 2024

View reviewed changes

Common/Core/RecoDecay.h Show resolved Hide resolved

fcatalan92 approved these changes Apr 15, 2024

View reviewed changes

ddobrigk approved these changes Apr 18, 2024

View reviewed changes

ddobrigk merged commit b545a83 into AliceO2Group:master Apr 18, 2024

ZFederica deleted the fix branch April 19, 2024 06:18

fcatalan92 mentioned this pull request Apr 22, 2024

PWGHF: fix task for efficiency calculation checking daughter production process #5748

Merged

Common: RecoDecay: Consider only particles coming from decay process when matching #5407

Common: RecoDecay: Consider only particles coming from decay process when matching #5407

Uh oh!

Conversation

ZFederica commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZFederica commented Mar 28, 2024

Uh oh!

alibuild commented Mar 28, 2024

Uh oh!

alibuild commented Mar 28, 2024

Uh oh!

vkucera commented Apr 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgrosa commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZFederica commented Apr 11, 2024

Uh oh!

vkucera commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZFederica commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Apr 12, 2024

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

ZFederica commented Apr 15, 2024

Uh oh!

Uh oh!

vkucera commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

ZFederica commented Mar 28, 2024 •

edited

Loading

vkucera commented Apr 11, 2024 •

edited

Loading

ZFederica commented Apr 12, 2024 •

edited

Loading