Skip to content

[PWGLF] Update PWFLF/Tasks/Nuspex/spectraTOF.cxx #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RD0407 wants to merge 45 commits into from
Closed

[PWGLF] Update PWFLF/Tasks/Nuspex/spectraTOF.cxx #10291

RD0407 wants to merge 45 commits into from

Conversation

@RD0407
Copy link
Contributor

@RD0407 RD0407 commented Mar 3, 2025

Fix bugs and add MC closure test

RD0407 and others added 30 commits January 26, 2025 11:02
@RD0407
Update spectraTOF.cxx
995d51a
@RD0407
Merge pull request #119 from RD0407/RD0407-patch-42
4c00db7 
[PWGLF] Update spectraTOF.cxx
@alibuild
Please consider the following formatting changes
3cf3822
@RD0407
Merge pull request #120 from alibuild/alibot-cleanup-9537
e5e4d74 
[PWGLF] Please consider the following formatting changes to AliceO2Group#9537
@RD0407
Merge branch 'AliceO2Group:master' into master
7f9f0f9
@RD0407
Update spectraTOF.cxx
48c0472
@RD0407
Merge pull request #121 from RD0407/RD0407-patch-43
4a5b8e8 
[PWGLF] Update spectraTOF.cxx
@RD0407
Merge branch 'AliceO2Group:master' into master
b320389
@RD0407
Update spectraTOF.cxx
f454ff3
@RD0407
Merge pull request #122 from RD0407/RD0407-patch-44
69b34bf 
[PWGLF] Update spectraTOF.cxx
@RD0407
Update spectraTOF.cxx
4e48f26
@RD0407
Update spectraTOF.cxx
5bf0cf3
@RD0407
Update spectraTOF.cxx
149cc4d
@RD0407
Merge pull request #123 from RD0407/RD0407-patch-45
5c05678 
[PWGLF] Update spectraTOF.cxx
@alibuild
Please consider the following formatting changes
a75ab8e
@RD0407
Merge pull request #124 from alibuild/alibot-cleanup-9621
5566fba 
[PWGLF] Please consider the following formatting changes to AliceO2Group#9621
@RD0407
Merge branch 'AliceO2Group:master' into master
f5c3d9a
@RD0407
Update spectraTOF.cxx
30cf9a8
@RD0407
Update spectraTOF.cxx
2d2b0de
@RD0407
Merge pull request #125 from RD0407/RD0407-patch-46
7d1154d 
[PWGLF] Update spectraTOF.cxx
@alibuild
Please consider the following formatting changes
d6612d8
@RD0407
Merge pull request #126 from alibuild/alibot-cleanup-9695
89911c8 
[PWGLF] Please consider the following formatting changes to AliceO2Group#9695
@RD0407
Merge branch 'AliceO2Group:master' into master
3ac7741
@RD0407
Merge branch 'AliceO2Group:master' into master
6429d9c
@RD0407
Update spectraTOF.cxx
9eafbdb
@RD0407
Update spectraTOF.cxx
8d3cc58
@RD0407
Update spectraTOF.cxx
6c60ce3
@RD0407
Update spectraTOF.cxx
06f9aa3
@alibuild
Please consider the following formatting changes
2b724dc
@RD0407
Merge pull request #129 from alibuild/alibot-cleanup-10290
597a63d 
Please consider the following formatting changes to AliceO2Group#10290
@github-actions github-actions bot added the pwglf label Mar 3, 2025
@github-actions github-actions bot changed the title Update PWFLF/Tasks/Nuspex/spectraTOF.cxx [PWGLF] Update PWFLF/Tasks/Nuspex/spectraTOF.cxx Mar 3, 2025
@alibuild alibuild mentioned this pull request Mar 3, 2025
Merged
@alibuild alibuild mentioned this pull request Mar 3, 2025
Merged
@alibuild alibuild mentioned this pull request Mar 3, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for e977216 at 2025-03-03 17:17:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10291-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1444:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10291-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTPC.cxx:1444:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Mar 3, 2025
Merged
@RD0407
Merge pull request #134 from alibuild/alibot-cleanup-10291
f355824 
Please consider the following formatting changes to AliceO2Group#10291
@chiarapinto chiarapinto marked this pull request as draft March 3, 2025 17:43
@chiarapinto
Copy link
Collaborator

chiarapinto commented Mar 3, 2025

Hi @RD0407, I converted the PR into a draft, so you can work on it. Once you fix the issues with the code you can move again the status to “Ready for review”.

@chiarapinto chiarapinto mentioned this pull request Mar 3, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for f355824 at 2025-03-03 18:57:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10291-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTPC.cxx:1444:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
ninja: build stopped: subcommand failed.

Full log here.

@RD0407 RD0407 marked this pull request as ready for review March 4, 2025 10:27
@RD0407 RD0407 closed this Mar 4, 2025
@alibuild
Copy link
Collaborator

alibuild commented Mar 4, 2025

Error while checking build/O2Physics/o2 for 445ca0a at 2025-03-04 12:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10291-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTPC.cxx:1444:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@njacazio njacazio Awaiting requested review from njacazio

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RD0407 @alibuild @chiarapinto