Skip to content

[PWGLF] Update PWGLF/Tasks/Nuspex/spectraTOF.cxx#10287

Closed
RD0407 wants to merge 0 commit intoAliceO2Group:masterfrom
RD0407:master
Closed

[PWGLF] Update PWGLF/Tasks/Nuspex/spectraTOF.cxx#10287
RD0407 wants to merge 0 commit intoAliceO2Group:masterfrom
RD0407:master

Conversation

@RD0407
Copy link
Contributor

@RD0407 RD0407 commented Mar 3, 2025

Added function for MC closure test

@github-actions github-actions bot added the pwglf label Mar 3, 2025
@github-actions github-actions bot changed the title Update PWGLF/Tasks/Nuspex/spectraTOF.cxx [PWGLF] Update PWGLF/Tasks/Nuspex/spectraTOF.cxx Mar 3, 2025
@alibuild alibuild mentioned this pull request Mar 3, 2025
Merged
RD0407 added a commit to RD0407/O2Physics that referenced this pull request Mar 3, 2025
@RD0407
Merge pull request #128 from alibuild/alibot-cleanup-10287
1404b5b 
[PWGLF] Please consider the following formatting changes to AliceO2Group#10287
@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for 0e27670 at 2025-03-03 13:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1444:38: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2518:12: error: unused variable 'hasParticleInFT0C' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2519:12: error: unused variable 'hasParticleInFT0A' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for 1404b5b at 2025-03-03 13:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1445:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2517:12: error: unused variable 'hasParticleInFT0C' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2518:12: error: unused variable 'hasParticleInFT0A' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for 7e00be1 at 2025-03-03 16:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1445:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2517:12: error: unused variable 'hasParticleInFT0C' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2518:12: error: unused variable 'hasParticleInFT0A' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for c306608 at 2025-03-03 16:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1445:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2517:12: error: unused variable 'hasParticleInFT0C' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2518:12: error: unused variable 'hasParticleInFT0A' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@chiarapinto
Copy link
Collaborator

chiarapinto commented Mar 3, 2025

Hi @RD0407, is this PR different from #10291 ? Please check and keep open only one. I mark this one as draft as well, while you figure it out :)

@chiarapinto chiarapinto marked this pull request as draft March 3, 2025 17:56
@alibuild
Copy link
Collaborator

alibuild commented Mar 3, 2025

Error while checking build/O2Physics/o2 for 8fb644b at 2025-03-03 19:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:1445:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2517:12: error: unused variable 'hasParticleInFT0C' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10287-slc9_x86-64/0/PWGLF/Tasks/Nuspex/spectraTOF.cxx:2518:12: error: unused variable 'hasParticleInFT0A' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@RD0407 RD0407 closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes

@alibuild alibuild Awaiting requested review from alibuild

@njacazio njacazio Awaiting requested review from njacazio

@skundu692 skundu692 Awaiting requested review from skundu692

@fmazzasc fmazzasc Awaiting requested review from fmazzasc

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RD0407 @alibuild @chiarapinto @maciacco