Fix #428: adding missing include for std::array#432
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Jun 28, 2017
Merged
Fix #428: adding missing include for std::array#432sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
std::array is used in test_DataDeflater.cxx, but the include was missing, some compilers seem to be more strict on that and fail. Also suppressing a warning by using the static_assert with two arguments (condition and error string)
Collaborator
|
Error while checking build/o2checkcode/o2-daq for f249474: Full log here. |
Collaborator
|
@matthiasrichter: Can you please also fix this /mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/0_O2_DAQ/0//Utilities/DataCompression/include/DataCompression/DataDeflater.h:1:1: error: missing or malformed copyright notice to make the code checker happy? |
Collaborator
|
As discussed in #428, there is a compile error on MacOs with Apple LLVM version 8.0.0 (clang-800.0.42.1): /Users/swenzel/alisw_new/sw/SOURCES/O2/dev/0/Utilities/aliceHLTwrapper/src/Component.cxx:169:13: error: use of undeclared identifier 'ENOKEY' This is super strange since you already seem to include the right header. Other symbols such as ENOSYS are found. |
Collaborator
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
AliceO2Group#432) Pubisher part can publish cells or digits upon user request. Digits and Cells have the same interface however digits type from now on purely stores raw ADCs from the digitizer (change signal type from float to short) and is therefore no longer suitable for the use of the tower signal after the raw fit. Decommissioning of the digit branch needs to be done in a second step, together with adaptions in the digits QC task.
mbroz84
pushed a commit
to mbroz84/AliceO2
that referenced
this pull request
Mar 16, 2022
* Code for PID analysis * Updated names, formatting and syntax * update CMakeLists source file name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::array is used in test_DataDeflater.cxx, but the include was
missing, some compilers seem to be more strict on that and fail.
Also suppressing a warning by using the static_assert with two
arguments (condition and error string)