Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tinymce to v6 #2671

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Update Tinymce to v6 #2671

merged 7 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. Update Tinymce to v6.8.2

    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a9d84e7 View commit details
    Browse the repository at this point in the history

  2. Fix setting min-height via attributes. 

    We allow setting the min-height via attribute. We need
a setter for this.
    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    dc997ea View commit details
    Browse the repository at this point in the history

  3. Fix Tinymce table plugin styles

    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2fe3e4c View commit details
    Browse the repository at this point in the history

  4. Remove table icons 

    There are too many icons that would have to be replaced.
RemixIcon has table edit icons, but not the vast amount
we need. Let's remove the table icons from from the iconset
to be consistent at least.
    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b2b39bb View commit details
    Browse the repository at this point in the history

  5. Use horizontal tabs for tinymce dialog navigation 

    Suits our dialog navigation layout
    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ac2cd1d View commit details
    Browse the repository at this point in the history

  6. Fix tinymce button styles if used in Solidus 

    Solidus has background images on all button tags and
Tinymce uses button tags for selects (sigh!).
    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ee6a191 View commit details
    Browse the repository at this point in the history

  7. Fix Tinymce input focus style if used in Solidus 

    Solidus has a harsh `!important` rule on all `input`s with
`tabindex=-1` and Tinymce has a tabindex=-1 on all inputs
(sigh!).
    @tvdeyen
    tvdeyen committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ab1f778 View commit details
    Browse the repository at this point in the history