Update Tinymce to v6 #2671
Merged
Update Tinymce to v6 #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow setting the min-height via attribute. We need a setter for this.
There are too many icons that would have to be replaced. RemixIcon has table edit icons, but not the vast amount we need. Let's remove the table icons from from the iconset to be consistent at least.
Suits our dialog navigation layout
Solidus has background images on all button tags and Tinymce uses button tags for selects (sigh!).
Solidus has a harsh `!important` rule on all `input`s with `tabindex=-1` and Tinymce has a tabindex=-1 on all inputs (sigh!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Updates bundled Tinymce to v6.8.2
Notable changes
Follow https://www.tiny.cloud/docs/tinymce/latest/migration-from-5x/ if you have any additional plugins installed or modified the default toolbar.
Checklist