Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Fix DOM ids and labels of ingredient editors #2534

Merged
merged 5 commits into from
Jul 31, 2023

Commits on Jul 6, 2023

  1. Fix disconnecting Tinymce intersection observer

    Before we were removing the intersection observer even
    if we are still on the same page.
    
    Now removing it were we need to, in the Turbo page change
    event.
    tvdeyen committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    49eb17c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Bump version to v7.0.1

    tvdeyen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    cae71d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Use selenium-webdriver instead of webdrivers gem

    Selenium-Webdriver now has a feature that makes the webdrivers gem
    obsolete: https://github.com/titusfortner/webdrivers#update-future-of-this-project
    mamhoff committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5578fc1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request AlchemyCMS#2532 from mamhoff/7.0-no-more-webdrivers

    [v7.0] Use selenium-webdriver instead of webdrivers gem
    tvdeyen authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a6c6564 View commit details
    Browse the repository at this point in the history
  3. Fix DOM ids and labels of ingredient editors

    The boolean ingredient editor label tag must
    not have a `for` attribute since it nests the input
    tag. That input does not need an `id` as it is
    nested. Solves an issue with non-clickable
    label on the checkbox.
    
    The image editor label must not have a `for`
    attribute as well, as there is no focusable form
    element.
    tvdeyen committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    15d2ac1 View commit details
    Browse the repository at this point in the history