[7.0] Fix DOM ids and labels of ingredient editors #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were removing the intersection observer even if we are still on the same page. Now removing it were we need to, in the Turbo page change event.
Selenium-Webdriver now has a feature that makes the webdrivers gem obsolete: https://github.com/titusfortner/webdrivers#update-future-of-this-project
[v7.0] Use selenium-webdriver instead of webdrivers gem
The boolean ingredient editor label tag must not have a `for` attribute since it nests the input tag. That input does not need an `id` as it is nested. Solves an issue with non-clickable label on the checkbox. The image editor label must not have a `for` attribute as well, as there is no focusable form element.
mamhoff
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2526 but for 7.0-stable