Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Kaminari::Helpers::Tag hack #2376

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Remove unused Kaminari::Helpers::Tag hack #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f04f6
Remove unused Kaminari::Helpers::Tag hack
tvdeyen Sep 21, 2022
44279b8
fix(elements_controller_spec): Store id before removing
tvdeyen Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/alchemy_cms.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,5 @@
require_relative "alchemy/taggable"
require_relative "alchemy/version"

# Require hacks
require_relative "kaminari/scoped_pagination_url_helper"

# Finally require Alchemy itself
require_relative "alchemy/engine"
12 changes: 0 additions & 12 deletions lib/kaminari/scoped_pagination_url_helper.rb
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions spec/libraries/kaminari/scoped_pagination_url_helper_spec.rb
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion spec/requests/alchemy/admin/elements_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@
let(:element) { create(:alchemy_element, :with_ingredients) }

it "removes Tinymce for richtext ingredients" do
text_id = element.ingredient_by_role(:text).id
delete admin_element_path(id: element.id, format: :js)
expect(response.body).to include("Alchemy.Tinymce.remove([#{element.ingredient_by_role(:text).id}]);")
expect(response.body).to include("Alchemy.Tinymce.remove([#{text_id}]);")
end
end
end
Expand Down