Remove unused Kaminari::Helpers::Tag hack #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced this to be able to pass the Alchemy route proxy into pagination links. We do not use this helper anywhere, though. Removing this global patch as this globally overrides Kaminari for all apps having Alchemy mounted. Closes AlchemyCMS#2375
This stopped working in Rails 7.0, but actually it remains a mistery why this has ever passed before.
mamhoff
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We introduced this to be able to pass the Alchemy route proxy into pagination links. We do not use this helper anywhere, though.
Removing this global patch as this globally overrides Kaminari for all apps having Alchemy mounted.
Closes #2375
Checklist