fix(Sitemap): Use response data #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-sitemap-response
branch
from
22e5f0a
to
26c4aa6
Compare
|
This needs #2271 |
mamhoff
approved these changes
Mar 24, 2022
Our ajax library returns the parsed json as response.data. The former was part of the fetch() api that we used before.
Enable forgery protection so we have a csrf-token in the dom that our ajax lib expects. Also wait for the sitemap spinner to disappear before acting with the dom with capybara
tvdeyen
force-pushed
the
fix-sitemap-response
branch
from
26c4aa6
to
671ce46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Our ajax library returns the parsed json as response.data. The former was part of the fetch() api that we used before.
Checklist