Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ajax: Send method override" #2271

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 24, 2022

What is this pull request for?

This reverts commit f183a5e.

The method override is not ending up in the Rails router as expected and leads to 404 errors (Route Not Found)

Relying on a properly configured Web-Server instead. Tested on several non-PaaS hosters as well as on PaaS Hosters
and it always works with the PATCH request.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team March 24, 2022 09:11
@tvdeyen tvdeyen mentioned this pull request Mar 24, 2022
2 tasks
@tvdeyen tvdeyen merged commit 2854944 into AlchemyCMS:main Mar 24, 2022
@tvdeyen tvdeyen deleted the revert-ajax-method-override branch March 24, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants