Remove spec that tests default data store value #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-data-store-for-mysql
branch
2 times, most recently
from
da75869
to
7292f59
Compare
In MySQL/MariaDB and sqlite you cannot set an default value to a json column. Since we use Rails' data store feature and this works without the default db value we can simply remove that spec.
tvdeyen
force-pushed
the
fix-data-store-for-mysql
branch
from
7292f59
to
4b55618
Compare
tvdeyen
changed the title
mamhoff
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not expect that an ingredient data is an empty Hash
In MySQL/MariaDB and sqlite you cannot set an default value
to a json column. Since we use Rails' data store feature
and this works without the default db value we can simply
remove that spec.
Follow up to #2183