Remove data store accessor from ingredient base class #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary before we started to use Rails' data store feature in AlchemyCMS#2171 This currently leads to weird bugs around active record dirty falsy thinking the attribute set is not dirty, leading to the data store not being saved.
mamhoff
approved these changes
Aug 27, 2021
|
What? Why has GitHub merged this if there where specs failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Remove data store accessor from ingredient base class
This was necessary before we started to use Rails' data store feature in
#2171
This currently leads to weird bugs around active record dirty falsy thinking
the attribute set is not dirty, leading
to the data store not being saved.
Checklist