Return only pages from current site in api #2169
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni...
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml
|
@afdev82 thanks, that makes sense. Would you mind to add a test that confirms this change? |
|
Curious... I just found that: ace6ccb |
|
I found that it was changed by: 02d7e1d |
|
Yes, please
|
As with the show action we do not want to return pages for other sites except the current one.
CanCanCan does not respect any scope set before `accessible_by`. We need to make sure the additional scopes get called afterwards.
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni...
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml
- Return only pages from current site in api [#2169](#2169) ([afdev82](https://github.com/afdev82)) - Improve cache key defaults for menus #2138 [#2160](#2160) ([oneiros](https://github.com/oneiros)) - generate picture thumbnails only for pictures with convertible format [#2130](#2130) ([afdev82](https://github.com/afdev82)) - Backport #2114 to v5.2 [#2116](#2116) ([afdev82](https://github.com/afdev82)) - Add webpacker tasks to Alchemy upgrader [#2115](#2115) ([dbwinger](https://github.com/dbwinger))
|
@tvdeyen @afdev82 I'm running into problems I think related to this. When I go to set a page on an EssenceLink content, the auto-complete input only shows pages for the site matching the host I'm currently on. That can work, but it's not ideal when managing multiple sites with different hosts. If one of my sites ("Test 1") is 'test1.com', and the other ("Test 1") is 'test2.com', that means if I'm editing a page on site "Test 2" at 'test1.com/admin/pages/1', the only pages I'm offered for links are ones on site "Test 1". It requires me signing into Alchemy Admin from the other domain "test2.com" in order to be able to set links. I think it should instead use the language of the page being edited in the case of EssenceLink contents. Am I missing something or is this a bug/missing feature? |
@dbwinger that sounds like a reasonable fix for that issue. We would need to pass the current pages language to the link overlay. Doable for sure. Mind to open a ticket and even try to work on a solution? |
|
@tvdeyen Sure I'll open a ticket, and I hope to get some time to work on it myself. |
What is this pull request for?
If we search the internal page to be linked when we create a node in the menu, the results span all the websites.
This is for me not necessary and it gives troubles if many pages have the same name and paths.
Notable changes (remove if none)
This PR filter the pages to be the ones available only in the current alchemy site.
Checklist