Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webpacker tasks to Alchemy upgrader #2115

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Add webpacker tasks to Alchemy upgrader #2115

merged 1 commit into from
Jun 7, 2021

Conversation

dbwinger
Copy link
Contributor

@dbwinger dbwinger commented Jun 5, 2021 •
edited
Loading

What is this pull request for?

Adds Alchemy 5 upgrade tasks to complete required wepbacker setup, mirroring installer tasks, run webpacker installer, add alchemy's npm package, and copy alchemy's webpack entry point.

Closes #1937

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change
    (I don't see any existing tests for the upgrader tasks, unless I'm missing them)

hound[bot]
hound bot reviewed Jun 5, 2021
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni... 
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml

@afdev82
Copy link
Contributor

afdev82 commented Jun 5, 2021

I was planning to work on that too, thank you for opening this!

@dbwinger
Copy link
Contributor Author

dbwinger commented Jun 5, 2021

I see a bunch of spec are failing with Dragonfly::ParamValidators::InvalidParameter errors. I can't see how that's related to my changes and wonder if anyone knows a quick answer to what's going on.

@tvdeyen
Copy link
Member

tvdeyen commented Jun 5, 2021

Unfortunately GitHub mobile does not show me which branch this is targeted. Assuming it's a 5.x branch it will most likely be due to the breaking 1.4 release of dragonfly. Pinning the version to < 1.4 should fix the builds.

hound[bot]
hound bot reviewed Jun 5, 2021
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni... 
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml

@dbwinger
Copy link
Contributor Author

dbwinger commented Jun 5, 2021

Thanks @tvdeyen . Yes, that was it. And yes, this PR is against 5.2-stable and should be backported to 5.1 and 5.0 since it affects the 5.0 upgrader.

@tvdeyen tvdeyen merged commit 9ca1ce5 into AlchemyCMS:5.2-stable Jun 7, 2021
@tvdeyen
Copy link
Member

tvdeyen commented Jun 7, 2021

@dbwinger thanks.

@dbwinger
Copy link
Contributor Author

dbwinger commented Jun 7, 2021

Thank you @tvdeyen. Will you take care of getting this into 5.0 and 5.1 or should I open PRs for those branches as well?

@tvdeyen
Copy link
Member

tvdeyen commented Jun 7, 2021

@dbwinger any help is appreciated.

@dbwinger dbwinger deleted the upgrader-webpacker branch June 9, 2021 15:05
dbwinger added a commit to dbwinger/alchemy_cms that referenced this pull request Jun 9, 2021
@dbwinger
Backport AlchemyCMS#2115 to v5.1
4584057
@dbwinger dbwinger mentioned this pull request Jun 9, 2021
Merged
dbwinger added a commit to dbwinger/alchemy_cms that referenced this pull request Jun 9, 2021
@dbwinger
Backport AlchemyCMS#2115 to v5.0
d2879a1
@dbwinger dbwinger mentioned this pull request Jun 9, 2021
Merged
tvdeyen added a commit that referenced this pull request Sep 15, 2021
@tvdeyen
Bump version to v5.0.5
6dc58d6 
- Backport #2115 to v5.0 [#2126](#2126) ([dbwinger](https://github.com/dbwinger))
- Fixate Dragonfly to < 1.4 [#2122](#2122) ([tvdeyen](https://github.com/tvdeyen))
- Backport #2114 to v5.0 [#2118](#2118) ([afdev82](https://github.com/afdev82))
tvdeyen added a commit that referenced this pull request Sep 15, 2021
@tvdeyen
Bump version to v5.1.5
d53c938 
- generate picture thumbnails only for pictures with convertible format [#2131](#2131) ([afdev82](https://github.com/afdev82))
- Backport #2115 to v5.1 [#2125](#2125) ([dbwinger](https://github.com/dbwinger))
- Backport #2114 to v5.1 [#2117](#2117) ([afdev82](https://github.com/afdev82))
tvdeyen added a commit that referenced this pull request Sep 15, 2021
@tvdeyen
Bump version to v5.2.2
90e346b 
- Return only pages from current site in api [#2169](#2169) ([afdev82](https://github.com/afdev82))
- Improve cache key defaults for menus #2138 [#2160](#2160) ([oneiros](https://github.com/oneiros))
- generate picture thumbnails only for pictures with convertible format [#2130](#2130) ([afdev82](https://github.com/afdev82))
- Backport #2114 to v5.2 [#2116](#2116) ([afdev82](https://github.com/afdev82))
- Add webpacker tasks to Alchemy upgrader [#2115](#2115) ([dbwinger](https://github.com/dbwinger))
gr8bit added a commit to bichinger/alchemy_cms that referenced this pull request Apr 12, 2022
@gr8bit
Merge branch '5.0-stable' of github.com:AlchemyCMS/alchemy_cms into a…
c4c134a 
…ctive-storage-integration

* '5.0-stable' of github.com:AlchemyCMS/alchemy_cms: (34 commits)
  Bump version to v5.0.10
  Add crop_resize Dragonfly processor
  make the admin error tracker customizable
  Bump npm package
  Bump version to v5.0.9
  Adjust tinymce skin assets urls again
  Bump npm package version to v5.0.8
  Bump version to v5.0.8
  Set stampable user_class_name without root identifier
  Use relative path for tinymce font-face
  Bump version to v5.0.7
  Make sure to install correct npm package
  Bump version to v5.0.6
  Use self_and_ancestors in page_active? helper
  Bump version to v5.0.5
  Bump NPM package version to 5.0.4
  Backport AlchemyCMS#2115 to v5.0
  Fixes i18n Jest specs
  expose translations in global Alchemy js object, AlchemyCMS#2113
  Fixate Dragonfly to < 1.4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbwinger @afdev82 @tvdeyen