Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "Visit page" button to "Link to new tab" #2058

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Convert "Visit page" button to "Link to new tab" #2058

merged 3 commits into from
Mar 30, 2021

Commits on Mar 30, 2021

  1. Refactor "Visit page" button to link to page 

    This allows an editor to stay in their Alchemy window while previewing
a page.
    @mamhoff
    mamhoff committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    27f8906 View commit details
    Browse the repository at this point in the history

  2. Remove visit action from admin pages controller 

    The benefit of this action was that it would unlock the page before
allowing the user to visit it. I think that's not necessarily a great
user experience, as an editor will probably only use the visit link to
quickly glance at the page without Alchemy present, and might not be
aware that this removes their lock on the page.
    @mamhoff
    mamhoff committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    28a09ac View commit details
    Browse the repository at this point in the history

  3. Do not run JS on visiting the page currently being edited

    @mamhoff
    mamhoff committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    4e6ee4c View commit details
    Browse the repository at this point in the history