Convert "Visit page" button to "Link to new tab" #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
changed the title
tvdeyen
reviewed
Mar 30, 2021
This allows an editor to stay in their Alchemy window while previewing a page.
The benefit of this action was that it would unlock the page before allowing the user to visit it. I think that's not necessarily a great user experience, as an editor will probably only use the visit link to quickly glance at the page without Alchemy present, and might not be aware that this removes their lock on the page.
mamhoff
force-pushed
the
preview-page-link
branch
from
7b9aade
to
4e6ee4c
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
In the admin edit page, editors can go and "visit" a page. I've always misunderstood this button as a link, and have very often tried to press shift while clicking on it in order to get it to display in a new tab - alas, to no avail. It was no link.
This makes it a link. It also removes the hidden functionality that the user's lock on the page would disappear silently.
Notable changes (remove if none)
See above.
Checklist