-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate auto_logout_time (4.6) #1843
Deprecate auto_logout_time (4.6) #1843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout Error: The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. The `Layout/IndentArray` cop has been renamed to `Layout/FirstArrayElementIndentation`. The `Layout/IndentHash` cop has been renamed to `Layout/FirstHashElementIndentation`. The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. The `Style/BracesAroundHashParameters` cop has been removed.
7821092
to
e5a7fbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ciao!
e5a7fbc
to
89b4cb6
Compare
# NOTE: This is only active in production environments | ||
# | ||
auto_logout_time: 30 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reverted.
- Use apt update instead of apt-get in GH action [#1865](#1865) ([tvdeyen](https://github.com/tvdeyen)) - Use depth for page tree serializer root_or_leaf [#1864](#1864) ([tvdeyen](https://github.com/tvdeyen)) - Fix sitemap wrapper height [#1861](#1861) ([tvdeyen](https://github.com/tvdeyen)) - Do not return the root page with API responses. [#1860](#1860) ([tvdeyen](https://github.com/tvdeyen)) - Introduce page.url_path and use it for alchemyPageSelect [#1859](#1859) ([tvdeyen](https://github.com/tvdeyen)) - Update Urlname translation [#1857](#1857) ([tvdeyen](https://github.com/tvdeyen)) - Show url name in Page tree [#1856](#1856) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate Page#visible attribute [#1855](#1855) ([tvdeyen](https://github.com/tvdeyen)) - 4.6: Re-add `auto_logout_time` configuration option [#1852](#1852) ([mamhoff](https://github.com/mamhoff)) - Backport ContentEditor to 4.6, deprecate removed methods on `Alchemy::Content` [#1847](#1847) ([mamhoff](https://github.com/mamhoff)) - Deprecate auto_logout_time (4.6) [#1843](#1843) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate require_ssl (4.6) [#1842](#1842) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate url_nesting configuration (4.6) [#1841](#1841) ([tvdeyen](https://github.com/tvdeyen)) - Allow page visible toggle (4.6) [#1838](#1838) ([tvdeyen](https://github.com/tvdeyen))
What is this pull request for?
This option has no effect. The only usage is in
alchemy-devise
to determine thelogged_in?
state of a user.Checklist