Allow page visible toggle (4.6) #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only check if any menus are present to attach a page to for the same language.
The Page#visible status is used to build the urlname of child pages. If a page is attached to a menu we should still be able to toggle that flag.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout Error: The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. The `Layout/IndentArray` cop has been renamed to `Layout/FirstArrayElementIndentation`. The `Layout/IndentHash` cop has been renamed to `Layout/FirstHashElementIndentation`. The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. The `Style/BracesAroundHashParameters` cop has been removed.
tvdeyen
changed the title
mamhoff
approved these changes
May 25, 2020
tvdeyen
added a commit
that referenced
this pull request
Jun 4, 2020
- Use apt update instead of apt-get in GH action [#1865](#1865) ([tvdeyen](https://github.com/tvdeyen)) - Use depth for page tree serializer root_or_leaf [#1864](#1864) ([tvdeyen](https://github.com/tvdeyen)) - Fix sitemap wrapper height [#1861](#1861) ([tvdeyen](https://github.com/tvdeyen)) - Do not return the root page with API responses. [#1860](#1860) ([tvdeyen](https://github.com/tvdeyen)) - Introduce page.url_path and use it for alchemyPageSelect [#1859](#1859) ([tvdeyen](https://github.com/tvdeyen)) - Update Urlname translation [#1857](#1857) ([tvdeyen](https://github.com/tvdeyen)) - Show url name in Page tree [#1856](#1856) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate Page#visible attribute [#1855](#1855) ([tvdeyen](https://github.com/tvdeyen)) - 4.6: Re-add `auto_logout_time` configuration option [#1852](#1852) ([mamhoff](https://github.com/mamhoff)) - Backport ContentEditor to 4.6, deprecate removed methods on `Alchemy::Content` [#1847](#1847) ([mamhoff](https://github.com/mamhoff)) - Deprecate auto_logout_time (4.6) [#1843](#1843) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate require_ssl (4.6) [#1842](#1842) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate url_nesting configuration (4.6) [#1841](#1841) ([tvdeyen](https://github.com/tvdeyen)) - Allow page visible toggle (4.6) [#1838](#1838) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
For 4.6-stable branch
Put back the "visible navigation" checkbox into the form of pages that are attached to a menu (node). This is necessary because Alchemy uses this flag on parent pages to build the urlname of a page. This might change in the future, but in 4.x it is still the case.
This changes the current checkbox "visible in navigation" into a button "attach to a menu" for sites having languages with menus available. The checkbox for the
visiblestatus changes from "visible in navigation" to "show in url of child pages".For sites not having any languages with menus this does not change at all. Think of the availability of menus toggle this feature. This is necessary because we still support the deprecated
render_navigationhelper in 4.xScreenshots
Checklist