Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element editor layout changes #1709

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Element editor layout changes #1709

merged 4 commits into from
Jan 8, 2020

Commits on Jan 8, 2020

  1. Simplify the element footer show-or-not code 

    The only question relevant for showing the element footer is
if we have content editors or tagging enabled. The nested elements
are irrelevant for this.
    @tvdeyen
    tvdeyen committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    a76e2cf View commit details
    Browse the repository at this point in the history

  2. Simplify the nestable elements style

    @tvdeyen
    tvdeyen committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    95f953b View commit details
    Browse the repository at this point in the history

  3. Rename show_element_footer helper 

    This helper actually tells us if the element is editable and if we should show the form
    @tvdeyen
    tvdeyen committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    fe2a59b View commit details
    Browse the repository at this point in the history

  4. Only show the element content editor form if necessary 

    If we do not have any contents to edit we do not need to render the form at all
    @tvdeyen
    tvdeyen committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    e97fbe9 View commit details
    Browse the repository at this point in the history