Element editor layout changes #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only question relevant for showing the element footer is if we have content editors or tagging enabled. The nested elements are irrelevant for this.
This helper actually tells us if the element is editable and if we should show the form
If we do not have any contents to edit we do not need to render the form at all
tvdeyen
added a commit
that referenced
this pull request
Jan 8, 2020
- Fix updating page preview after element create/save [#1710](#1710) ([tvdeyen](https://github.com/tvdeyen)) - Element editor layout changes [#1709](#1709) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy.user_class_primary_key setting [#1708](#1708) ([tvdeyen](https://github.com/tvdeyen)) - Add Element views upgrade tasks [#1707](#1707) ([tvdeyen](https://github.com/tvdeyen)) - Use postMessage to send messages between preview and element windows [#1704](#1704) ([tvdeyen](https://github.com/tvdeyen))
tvdeyen
added a commit
that referenced
this pull request
Jan 8, 2020
- Fix updating page preview after element create/save [#1710](#1710) ([tvdeyen](https://github.com/tvdeyen)) - Element editor layout changes [#1709](#1709) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy.user_class_primary_key setting [#1708](#1708) ([tvdeyen](https://github.com/tvdeyen)) - Add Element views upgrade tasks [#1707](#1707) ([tvdeyen](https://github.com/tvdeyen)) - Use postMessage to send messages between preview and element windows [#1704](#1704) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Some internal changes (mostly simplifications) about how we render the element editor partials.