Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to use pyproject.toml #194

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

RommelLayco
Copy link
Contributor

This is to ensure that the project meets the standard packing guidelines in PEP-0621, and that the version of the package meets PEP-440

@RommelLayco RommelLayco requested a review from a team March 27, 2024 01:43
@RommelLayco RommelLayco force-pushed the RommelLayco-pyproject-toml branch 5 times, most recently from a5c7bb8 to 2079132 Compare March 27, 2024 07:30
This is to ensure that the project meets the standard packing guidelines
in PEP-0621, and that the version of the package meets PEP-440
This is to ensure that the test tests/system/test_astacus.py:test_astacus
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (7a4b1ae) to head (ed10795).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #194       +/-   ##
===========================================
- Coverage   89.10%   78.90%   -10.21%     
===========================================
  Files         144      142        -2     
  Lines       10216    10173       -43     
===========================================
- Hits         9103     8027     -1076     
- Misses       1113     2146     +1033     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Run black to format code
@RommelLayco RommelLayco marked this pull request as draft March 27, 2024 20:36
@RommelLayco RommelLayco marked this pull request as ready for review March 27, 2024 22:09
@facetoe facetoe merged commit d6f28c5 into Aiven-Open:main Mar 28, 2024
3 checks passed
RommelLayco added a commit that referenced this pull request Apr 1, 2024
Update dev dependencies to at least be the same or newer as it was previously before #194
@alanfranz
Copy link
Contributor

@RommelLayco automagic version setting for this doesn't seem to work without a .git directory (which is what we're using when build the package in aiven-core). Also, is there any way to manually set the version from "outside" at build time?

And, it seems the gh action was updated but there's no Makefile target to actually create the astacus version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants