Fix astacus/version issues #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations (.e.g. when building packages from aiven-core) it could happen that the wrong .git directory is found, causing a total version mismatch. This target should work if and only if we've got an actual .git directory for the current project, and fail otherwise.
We don't want to have version automatically generated, as it can cause mistakes. We let users generate the version file if it's really needed.
alanfranz
force-pushed
the
alanfranz-versioning
branch
3 times, most recently
from
bf4e3f6
to
47d7ef1
Compare
Some issues where found with version generation; version didn't follow pep-440 standards, and it relied on git for actual fetching, while we may want to override the version from outside to match the actual version from the rpm package we build. Also, we don't want generation to happen automagically, but intentionally, so we had clear targets for what should be happening.
We don't want setup.py to do anything magic; it should just use the already-set version, which should be previously generated.
Target is unused, remove it.
alanfranz
force-pushed
the
alanfranz-versioning
branch
2 times, most recently
from
0080cdc
to
29b8340
Compare
We need to generate the version at the right moment, before full requirements need to be installed.
alanfranz
force-pushed
the
alanfranz-versioning
branch
from
29b8340
to
b507269
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 89.10% 89.07% -0.04%
==========================================
Files 144 144
Lines 10216 10220 +4
==========================================
Hits 9103 9103
- Misses 1113 1117 +4 ☔ View full report in Codecov by Sentry. |
aris-aiven
requested changes
Mar 28, 2024
|
I'm not sure what should I do anymore. It seems that a #194 was merged before this and touched the same files. But I don't understand whether it addresses the same concerns. |
|
it seems this was already solved independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astacus relied on autogenerated versioning from git which could happen or change without real knowledge of the developer, and could cause issues if an accidental git directory was found in a parent when using astacus from a non-git tarball.
This PR:
It seems that we're using all possible packaging files and approaches - multiple requirements files, pyproject, setup.py AND setup.cfg - I didn't want to enter that packaging-related discussion because I couldn't see the end of it, so I just took the existing versioning code and made it predictable & error-proof, I didn't change the "current way of doing things".