Skip to content

Fix Windows compatibility issue in add_exit_handlers() for aikido_background_process.py #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 3 commits into from
Dec 1, 2025
Merged

Fix Windows compatibility issue in add_exit_handlers() for aikido_background_process.py #532

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e540129
Fix invalid exit handlers for windows
QRouland Nov 30, 2025
8d198ab
fix linting issue for exit handlers for Windows commit
QRouland Nov 30, 2025
e3e2598
Update aikido_zen/background_process/aikido_background_process.py
bitterpanda63 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions aikido_zen/background_process/aikido_background_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import sched
import traceback
import sys
import platform
from threading import Thread
from queue import Queue
from aikido_zen.helpers.logging import logger
Expand Down Expand Up @@ -118,7 +119,11 @@ def add_exit_handlers():
def exit_gracefully(sig, frame):
sys.exit(0)

current_platform = platform.system()

signal.signal(signal.SIGINT, exit_gracefully)
signal.signal(signal.SIGTERM, exit_gracefully)
signal.signal(signal.SIGQUIT, exit_gracefully)
signal.signal(signal.SIGHUP, exit_gracefully)

if current_platform in ("Linux", "Darwin"):
signal.signal(signal.SIGQUIT, exit_gracefully)
signal.signal(signal.SIGHUP, exit_gracefully)