Fix Windows compatibility issue in add_exit_handlers() for aikido_background_process.py
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@QRouland Hi, thanks for creating a pull request! We'll review the PR soon. Could you check the linting errors? Thanks! |
Contributor
Author
|
@hansott I fixed the linting issue. If you'd prefer, I can squash this into the original commit before merging. Just let me know! |
bitterpanda63
approved these changes
Dec 1, 2025
Member
|
Looks good! Thanks for the contribution, We'll make a release fixing this issue ASAP :) |
Member
|
Could you test that v1.2.27 now also fixes the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 37f2a44f31f9cc30011b64f22cdb8fee5b9bf46e introduced
add_exit_handlers()inaikido_background_process.py, but it breaks Windows compatibility because the signalsSIGQUITandSIGHUPare only available on Unix-based systems (Linux and Darwin). As a result, the background process crashes on Windows during startup.This pull request fixes
add_exit_handlers()to support Windows compatibility by handling platform-specific signals.