Modularize passStyleOf #3571
Merged
Modularize passStyleOf #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-modular-passables
branch
from
d47d15e
to
9d1ab8b
Compare
erights
force-pushed
the
markm-modular-passables
branch
from
a7dfc99
to
726f264
Compare
michaelfig
approved these changes
Aug 3, 2021
erights
force-pushed
the
markm-modular-passables
branch
from
3233c3c
to
03b18fa
Compare
erights
force-pushed
the
markm-modular-passables
branch
from
03b18fa
to
dd69652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor: A major internal refactoring, to set things up for upcoming big changes. But this refactor by itself should have no observable effects.
Well, except for the following, which affects no current code:
Before this PR, in order to allow malformed errors to be passed through marshal, we had
passStyleOfvalidate them ascopyError, which could therefore be stores within passable structures. The allowed malformedness included the possibility of extra properties leading to surprising power. These would not be passed, so there was no distributed security problem. But the possibility of these extra properties on a Passable creates a local hazard. In this PR, malformed errors are passable in the same way, but are no longer considered Passable.Well formed errors are still Passable. However errors are no longer Comparable. They cannot be compared using sameStructure.
I have separately verified that this PR in compatible with #3525