fix: review comments

Agoric · Aug 3, 2021 · 3233c3c · 3233c3c
1 parent 86a45be
commit 3233c3c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/packages/marshal/src/helpers/copyArray.js b/packages/marshal/src/helpers/copyArray.js
@@ -35,11 +35,15 @@ export const CopyArrayHelper = harden({
       X`Malformed array: ${candidate}`,
       TypeError,
     );
+    // Since we're already ensured candidate is an array, it should not be
+    // possible for the following test to fail
+    checkNormalProperty(candidate, 'length', 'string', false, assertChecker);
     const len = candidate.length;
     for (let i = 0; i < len; i += 1) {
       checkNormalProperty(candidate, i, 'number', true, assertChecker);
     }
     assert(
+      // +1 for the 'length' property itself.
       ownKeys(candidate).length === len + 1,
       X`Arrays must not have non-indexes: ${candidate}`,
       TypeError,

diff --git a/packages/marshal/src/helpers/passStyleHelpers.js b/packages/marshal/src/helpers/passStyleHelpers.js
@@ -39,7 +39,7 @@ export const PASS_STYLE = Symbol.for('passStyle');
  * doing so, it's inheritance might change after the `PASS_STYLE`
  * check below.
  *
- * @param {*} func
+ * @param {any} func
  * @returns {boolean}
  */
 export const canBeMethod = func =>

diff --git a/packages/marshal/src/passStyleOf.js b/packages/marshal/src/passStyleOf.js
@@ -196,4 +196,4 @@ export const everyPassableChild = (passable, fn) => {
   }
   return true;
 };
-harden({ everyPassable: everyPassableChild });
+harden(everyPassableChild);
diff --git a/packages/marshal/src/structure.js b/packages/marshal/src/structure.js
@@ -67,9 +67,6 @@ const isStructureInternal = passable => {
 const structureCache = new WeakMap();
 
 /**
- * If `passable` is not a Passable, throw. Otherwise say whether it is
- * structure.
- *
  * @param {Passable} passable
  * @returns {boolean}
  */
@@ -150,7 +147,7 @@ export const fulfillToStructure = passable => {
 harden(fulfillToStructure);
 
 /**
- * This internal recursion may assume that `left` and `right` and
+ * This internal recursion may assume that `left` and `right` are
  * Structures, since `sameStructure` guards that, and the guarantee is
  * deep.
  *