Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template url to be modified via env #1965

Closed
wants to merge 3 commits into from
Closed

Allow template url to be modified via env #1965

wants to merge 3 commits into from

Conversation

tarunwadhwa-paypay
Copy link

@tarunwadhwa-paypay tarunwadhwa-paypay commented Aug 5, 2024

Addresses - #1964

Allowing docker hub's template URL to be flexible to allow docker proxies to list tags without issues.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 5, 2024
Copy link

vercel bot commented Aug 5, 2024

@tarunwadhwa-paypay is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 7:05pm

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me. The problem is probably something that a number of enterprises would have.

The DOCKER_HUB_URL and it's variable can be removed since they are not used anymore.

@aybruhm @aakrem what do you think? Are there changes in cloud / ee that would result from this?

@tarunwadhwa-paypay
Copy link
Author

Sorry for the inconvenience, I will be closing this PR and re-raising it again from my other GitHub account. 🙇

@tarunwadhwa-paypay tarunwadhwa-paypay deleted the tarunwadhwa/flexible_template_url branch August 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend devops size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants