Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker URL for fetching Templates flexible #1964

Open
tarunwadhwa-paypay opened this issue Aug 5, 2024 · 0 comments · May be fixed by #2075
Open

Make Docker URL for fetching Templates flexible #1964

tarunwadhwa-paypay opened this issue Aug 5, 2024 · 0 comments · May be fixed by #2075

Comments

@tarunwadhwa-paypay
Copy link

Is your feature request related to a problem? Please describe.

My company uses a proxy for fetching docker images (which allows caching if needed). The endpoint for listing tags is different from docker hub endpoint. But since /tags is hardcoded here, I cannot simply set the DOCKER_HUB_URL value to use my custom proxy

Describe the solution you'd like

I will be open to raising a PR if you feel this can be added.
Proposed solution -
Create a template URL in env config. Something like -
- DOCKER_HUB_TEMPLATE_URL=https://hub.docker.com/v2/repositories/{repo_name}/tags
and code can simply format the repo_name in code

Although the original variable (DOCKER_HUB_URL) is not being used anywhere, hardcoding /tags in value might not keep code extensible, hence new variable altogether

Describe alternatives you've considered
Nothing possible as such since /tags will give 404 for our proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant