feat: add limit orders #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
2 times, most recently
from
05274f6 to
a9f1c22
Compare
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
from
10fd47a to
978f457
Compare
chore: added terms and cons transaction signing chore: added constant for sign & terms key refactor: removed terms & cons unused code chore: updated dtos chore: update DTO chore: added status to overview chore: update limit addys chore: remove back indexer fetch chore: handle new architecture chore: typo chore: update status & add error msg chore: add batch cancellation
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
from
a69dc9f to
1df3f54
Compare
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
from
17a552c to
22ff425
Compare
| return { | ||
| orderId: Helpers.addLeadingZeroesToType(fields.order_id), | ||
| user: Helpers.addLeadingZeroesToType(fields.user), | ||
| // TODO: - should i convert to string? |
There was a problem hiding this comment.
event return public key as a vector of bytes, so i left the q if should i convert it to a string value (for future usage mb) or may keep as an array.
| @@ -71,7 +71,7 @@ export type DcaClosedOrderEventOnChain = EventOnChain<{ | |||
|
|
|||
| export type DcaExecutedTradeEventOnChain = EventOnChain<{ | |||
There was a problem hiding this comment.
see below comments on moving code to fe
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
2 times, most recently
from
ed3a780 to
b905b13
Compare
Fedor-Aftermath
force-pushed
the
fedor/limit
branch
from
b905b13 to
236d394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit Orders
Af Users
DCA
Configs