chore: review fixes

src/general/utils/casting.ts

@@ -16,7 +16,6 @@ import { BcsTypeName } from "../types/castingTypes";
 import { SuiObjectResponse } from "@mysten/sui/client";
 import { NftsApiCasting } from "../nfts/nftsApiCasting";
 import { DcaApiCasting } from "../../packages/dca/api/dcaApiCasting";
-import { LimitOrdersApiCasting } from "../../packages/limitOrders/api/limitOrdersApiCasting";
 
 /**
  * Utility class for casting and conversion functions.
@@ -38,7 +37,6 @@ export class Casting {
 	public static farms = FarmsApiCasting;
 	public static nfts = NftsApiCasting;
 	public static dca = DcaApiCasting;
-	public static limit = LimitOrdersApiCasting;
 
 	// =========================================================================
 	//  Constants

src/packages/limitOrders/api/limitOrdersApi.ts

@@ -1,22 +1,8 @@
 import { AftermathApi } from "../../../general/providers";
-import { AnyObjectType, LimitAddresses, SuiAddress } from "../../../types";
+import { AnyObjectType, LimitAddresses } from "../../../types";
 import { EventsApiHelpers } from "../../../general/apiHelpers/eventsApiHelpers";
 
 export class LimitOrdersApi {
-	// =========================================================================
-	// Constants
-	// =========================================================================
-
-	private static readonly constants = {
-		moduleNames: {
-			limit: "order",
-			events: "events",
-		},
-		eventNames: {
-			createdOrder: "CreatedOrderEvent",
-		},
-	};
-
 	// =========================================================================
 	// Class Members
 	// =========================================================================
@@ -51,7 +37,7 @@ export class LimitOrdersApi {
 	private createdOrderEventType = () =>
 		EventsApiHelpers.createEventType(
 			this.addresses.packages.limit,
-			LimitOrdersApi.constants.moduleNames.events,
-			LimitOrdersApi.constants.eventNames.createdOrder
+			"events",
+			"CreatedOrderEvent"
 		);
 }

src/packages/limitOrders/limitOrders.ts

@@ -1,11 +1,11 @@
-import { ObjectId, SuiNetwork } from "../../types";
+import { CoinType, ObjectId, SuiNetwork } from "../../types";
 import { Caller } from "../../general/utils/caller";
 import { AftermathApi } from "../../general/providers";
 import { SuiAddress } from "../../types";
 import {
-	ApiLimitOrdersOwnedBody,
-	ApiLimitOrdersTransactionForCreateOrderBody,
-	ApiLimitOrdersTransactionForCancelOrderBody,
+	ApiLimitOrdersPastOrdersOwnedBody,
+	ApiLimitOrdersCreateOrderTransactionBody,
+	ApiLimitOrdersCancelOrderTransactionBody,
 	LimitOrderObject,
 	ApiLimitOrdersActiveOrdersOwnedBody,
 } from "./limitOrdersTypes";
@@ -59,10 +59,10 @@ export class LimitOrders extends Caller {
 	 */
 
 	public async getPastLimitOrders(inputs: { walletAddress: SuiAddress }) {
-		return this.fetchApi<LimitOrderObject[], ApiLimitOrdersOwnedBody>(
-			"orders/past",
-			inputs
-		);
+		return this.fetchApi<
+			LimitOrderObject[],
+			ApiLimitOrdersPastOrdersOwnedBody
+		>("orders/past", inputs);
 	}
 
 	// =========================================================================
@@ -71,14 +71,14 @@ export class LimitOrders extends Caller {
 
 	/**
 	 * Fetches the API transaction for creating Limit order.
-	 * @param { ApiLimitOrdersTransactionForCreateOrderBody } inputs - The inputs for the transaction.
+	 * @param { ApiLimitOrdersCreateOrderTransactionBody } inputs - The inputs for the transaction.
 	 * @returns { Promise<Transaction> } A promise that resolves with the API transaction.
 	 */
 
 	public async getCreateLimitOrderTx(
-		inputs: ApiLimitOrdersTransactionForCreateOrderBody
+		inputs: ApiLimitOrdersCreateOrderTransactionBody
 	): Promise<Transaction> {
-		return this.fetchApiTransaction<ApiLimitOrdersTransactionForCreateOrderBody>(
+		return this.fetchApiTransaction<ApiLimitOrdersCreateOrderTransactionBody>(
 			"transactions/create-order",
 			inputs
 		);
@@ -91,12 +91,12 @@ export class LimitOrders extends Caller {
 	 */
 
 	public async cancelLimitOrder(
-		inputs: ApiLimitOrdersTransactionForCancelOrderBody
+		inputs: ApiLimitOrdersCancelOrderTransactionBody
 	): Promise<boolean> {
-		return this.fetchApi<
-			boolean,
-			ApiLimitOrdersTransactionForCancelOrderBody
-		>(`interactions/cancel-order`, inputs);
+		return this.fetchApi<boolean, ApiLimitOrdersCancelOrderTransactionBody>(
+			`interactions/cancel-order`,
+			inputs
+		);
 	}
 
 	// =========================================================================
@@ -121,4 +121,24 @@ export class LimitOrders extends Caller {
 			order_object_ids: inputs.orderIds,
 		};
 	}
+
+	// =========================================================================
+	// Configuration
+	// =========================================================================
+
+	/**
+	 * Method for getting a minimum allowable order size.
+	 * @returns Minimum order size in usd.
+	 */
+
+	public async getMinOrderSize() {
+		return this.fetchApi<
+			| {
+					minOrderCoinType: CoinType;
+					minOrderSizeUsd: number;
+			  }
+			| undefined,
+			undefined
+		>("min-order-size-usd");
+	}
 }

src/packages/limitOrders/limitOrdersTypes.ts

@@ -20,7 +20,7 @@ export interface LimitOrdersIntegratorFeeData {
 //  Initialize Order Transaction
 // =========================================================================
 
-export interface ApiLimitOrdersTransactionForCreateOrderBody {
+export interface ApiLimitOrdersCreateOrderTransactionBody {
 	walletAddress: SuiAddress;
 	allocateCoinType: CoinType;
 	allocateCoinAmount: Balance;
@@ -36,7 +36,7 @@ export interface ApiLimitOrdersTransactionForCreateOrderBody {
 // Cancel Order Transaction
 // =========================================================================
 
-export interface ApiLimitOrdersTransactionForCancelOrderBody {
+export interface ApiLimitOrdersCancelOrderTransactionBody {
 	walletAddress: SuiAddress;
 	bytes: string;
 	signature: string;
@@ -46,7 +46,7 @@ export interface ApiLimitOrdersTransactionForCancelOrderBody {
 //  Limit Order Fetch
 // =========================================================================
 
-export type LimitOrdersIndexerOrderStatus =
+export type LimitOrdersOrderStatus =
 	| "Active"
 	| "Canceled"
 	| "Failed"
@@ -80,32 +80,16 @@ export interface LimitOrderObject {
 		tnxDigest: TransactionDigest;
 	};
 	expiry: Timestamp;
-	status: LimitOrdersIndexerOrderStatus | undefined;
+	status: LimitOrdersOrderStatus | undefined;
 	error: string | undefined;
 	integratorFee?: LimitOrdersIntegratorFeeData;
 }
 
-// =========================================================================
-//  Limit Orders Events
-// =========================================================================
-
-export interface LimitOrdersCreatedOrderEvent extends Event {
-	orderId: ObjectId;
-	user: SuiAddress;
-	userPublicKey: Uint8Array;
-	recipient: SuiAddress;
-	inputAmount: Balance;
-	inputType: CoinType;
-	outputType: CoinType;
-	gasAmount: Balance;
-	encryptedFields: Uint8Array;
-}
-
 // =========================================================================
 //  Owned Limit Orders
 // =========================================================================
 
-export interface ApiLimitOrdersOwnedBody {
+export interface ApiLimitOrdersPastOrdersOwnedBody {
 	walletAddress: SuiAddress;
 }
 

src/packages/userData/userData.ts

@@ -34,7 +34,7 @@ export class UserData extends Caller {
 
 	public async getUserPublicKey(
 		inputs: ApiUserDataOwnedBody
-	): Promise<string | undefined | null> {
+	): Promise<string | undefined | "None"> {
 		return this.fetchApi<string | undefined, ApiUserDataOwnedBody>(
 			`public-key`,
 			inputs