add spinner for paypal express flow #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanikantsingh
requested review from
maassenbas,
amihajlovski and
zenit2001
as code owners
shanikantsingh
force-pushed
the
feature/SFI-762-spinner
branch
from
f7e1fe6
to
06c96c6
Compare
|
amihajlovski
approved these changes
Jun 6, 2024
zenit2001
approved these changes
Jun 7, 2024
zenit2001
merged commit 914ce2b
into
feature/SFI-42-paypal-express
14 of 17 checks passed
zenit2001
added a commit
that referenced
this pull request
Jul 23, 2024
* Rendering PayPal Expres button (#1076) * Paypal express payment (#1077) * Merchant reference set for PayPal Express (#1080) * Populate payment instrument fields for PayPal Express (#1081) * Adding the possibility to enable/disable paypal express from BM (#1085) * feat: adding the possibility to enable/disable paypal ecs from BM * chore: linting * fix: fixing klarna e2e test * PayPal Express update order (#1086) * feat: paypalUpdateOrder endpoint * test: unit tests and jsdoc annotations * feat: paypal update order * feat(SFI-696): show paypal express if enabled in BM * chore(SFI-696): add sonar properties file * refactor(SFI-696): function to create redirectUrl * feat(SFI-696): add stacktrace for error and fatal logs * chore(SFI-696): exclude e2e tests from sonar * fix(SFI-696): clear session.privacy data for paypal express * chore(SFI-696): undo changes to cartridges * fix(SFI-696): zero-auth flow * add spinner for paypal express flow (#1091) * Added the review page template and controller to render it (#1096) * Place order button for express payments on review page (#1112) * feat(SFI-790): new template for checkout review button * feat(SFI-789): handle payments details call from checkout review page * feat(SFI-789): create basket view data on express review page * feat(SFI-789): create basket view data on express review page * chore: merging develop into SFI-42 and adding required mocks (#1115) * Added e2e tests for paypal express (#1117) * test(SFI-798): paypal express unit tests (#1121) * fix: fixing apple pay express flow --------- Co-authored-by: Shani <31096696+shanikantsingh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Tested scenarios
Description of tested scenarios:
Fixed issue: #-SFI-762