Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paypal express payment #1077

Merged

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented May 1, 2024

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Enabling PayPal Express payments
  • What existing problem does this pull request solve?
    Completes a PayPal express payment with handling of the shopper data that comes from PayPal.
    The confirmation page flow, shipping changes and BM data will follow.

Tested scenarios

Description of tested scenarios:

  • PayPal express flow
  • Normal PayPal flow

Fixed issue: SFI-695

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@zenit2001 zenit2001 marked this pull request as ready for review May 1, 2024 13:59
@zenit2001 zenit2001 added the new New Feature label May 2, 2024
@zenit2001 zenit2001 merged commit faa5983 into feature/SFI-42-paypal-express May 2, 2024
16 of 17 checks passed
@zenit2001 zenit2001 deleted the feature/SFI-695-paypal_payments_call branch May 2, 2024 11:31
zenit2001 added a commit that referenced this pull request Jul 23, 2024
* Rendering PayPal Expres button (#1076)

* Paypal express payment (#1077)

* Merchant reference set for PayPal Express (#1080)

* Populate payment instrument fields for PayPal Express (#1081)

* Adding the possibility to enable/disable paypal express from BM (#1085)

* feat: adding the possibility to enable/disable paypal ecs from BM

* chore: linting

* fix: fixing klarna e2e test

* PayPal Express update order (#1086)

* feat: paypalUpdateOrder endpoint

* test: unit tests and jsdoc annotations

* feat: paypal update order

* feat(SFI-696): show paypal express if enabled in BM

* chore(SFI-696): add sonar properties file

* refactor(SFI-696): function to create redirectUrl

* feat(SFI-696): add stacktrace for error and fatal logs

* chore(SFI-696): exclude e2e tests from sonar

* fix(SFI-696): clear session.privacy data for paypal express

* chore(SFI-696): undo changes to cartridges

* fix(SFI-696): zero-auth flow

* add spinner for paypal express flow (#1091)

* Added the review page template and controller to render it (#1096)

* Place order button for express payments on review page (#1112)

* feat(SFI-790): new template for checkout review button

* feat(SFI-789): handle payments details call from checkout review page

* feat(SFI-789): create basket view data on express review page

* feat(SFI-789): create basket view data on express review page

* chore: merging develop into SFI-42 and adding required mocks (#1115)

* Added e2e tests for paypal express (#1117)

* test(SFI-798): paypal express unit tests (#1121)

* fix: fixing apple pay express flow

---------

Co-authored-by: Shani <31096696+shanikantsingh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants