Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2436 Adding References in report for renovator. #2442

Merged
merged 2 commits into from
Oct 15, 2020
Merged

#2436 Adding References in report for renovator. #2442

merged 2 commits into from
Oct 15, 2020

Conversation

mvkp737
Copy link
Contributor

@mvkp737 mvkp737 commented Oct 15, 2020

#2436 Adding references in report for renovator.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6070

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 55.38%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/processes/renovator/Renovator.java 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/processes/renovator/Renovator.java 1 78.89%
Totals Coverage Status
Change from base Build 6063: -0.002%
Covered Lines: 15760
Relevant Lines: 28458
💛 - Coveralls

@axp235
Copy link

axp235 commented Oct 15, 2020

@badvision : Please review and provide feedback

CC : @mxp737

@axp235 axp235 mentioned this pull request Oct 15, 2020
Closed
badvision
badvision approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks for your contribution!

@badvision badvision merged commit cceec77 into Adobe-Consulting-Services:master Oct 15, 2020
@axp235
Copy link

axp235 commented Nov 3, 2020

@davidjgonzalez : Can you please consider this as an enhancement for release "4.9.0"?

CC : @mxp737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badvision badvision badvision approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mvkp737 @coveralls @axp235 @badvision @mxp737