Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Contributor Rights #2440

Closed
axp235 opened this issue Oct 14, 2020 · 3 comments
Closed

Request Contributor Rights #2440

axp235 opened this issue Oct 14, 2020 · 3 comments
Labels

Comments

@axp235
Copy link

axp235 commented Oct 14, 2020

Requesting contributor rights so I participate in reviews and solve the following issues

#2436
#2438
#2439

@badvision
Copy link
Contributor

I'm very excited for your contributions to ACS Commons. For now can you comment on these issues? Also mention me in the reviews and I'll prioritize the review and acceptance of them once all the automated rules are happy with the pull requests. I saw a code complexity issue on one of them that needs to be resolved (and yes, it is kind of an important rule that we observe low cyclomatic complexity -- it makes unit testing a lot easier as well as code clarity/maintenance.)

@axp235
Copy link
Author

axp235 commented Oct 15, 2020

@badvision I have tagged you for review on PR #2442 after fixing the cyclomatic complexity issue.

We are having issues with another PR #2443 It shows some Test Failures that we don't see in our Local and wanted to check if there is a way to see the Surefire reports and if there are any tips that we should consider for our Local Travis setup

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@stale stale bot closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants