Fix: show/hide widgets features cannot handle complex input fields like Image or FileUpload #1745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the show/hide-widgets features works only for simple dialog fields. More complex dialog fields of Coral UI using a wrapper DIV (e.g. Image, FileUpload), and the jQuery selector of show/hide-widgets will hide the field, but never unhides it.
This is because the css-class is assigned to the wrapper DIV, while the "showhidetargetvalue" is rendered at the main input field. I extended the jQuery selector to unhide also dialog-field, when they contain an input-element with showhidetargetvalue.
The following cq:dialog is an example, that works after the fix (and not before).