Skip to content

Commit

Permalink
Merge pull request #1745 from alberndt/defect/ui-widgets-show-hide-wi…
Browse files Browse the repository at this point in the history
…dgets/image-component-cannot-be-unhidden

Fix: show/hide widgets features cannot handle complex input fields like Image or FileUpload
  • Loading branch information
justinedelson authored Feb 12, 2019
2 parents 0772363 + 25a25d2 commit 38b4155
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
- #1700 - MCP Forms framework now tracks client libraries required for components as needed

### Fixed
- Fix: Show/hide widgets: feature can now also show/hide complex fields like Image or FileUpload
- #1724 - AemEnvironmentIndicatorFilterTest.testDisallowedWcmMode is failed because of caret in windows
- #1699 - MCP UI doesn't work because of StackOverflowError exception
- #1692 - HttpCache: Refactored resource / group config extensions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@

// unhide the target element that contains the selected value as data-showhidetargetvalue attribute
function showTarget(target, value){
$(target).filter("[data-showhidetargetvalue*='" + value + "']").each(function() {
$(target).filter("[data-showhidetargetvalue*='" + value + "'],:has([data-showhidetargetvalue*='" + value + "'])").each(function() {
$(this).removeClass('hide'); //If target is a container, unhides the container
$(this).closest('.coral-Form-fieldwrapper').removeClass('hide'); // Unhides the target field wrapper. Thus, displaying label, quicktip etc.
});
Expand Down

0 comments on commit 38b4155

Please sign in to comment.